feat: implement authorization code flow for hca prod (ma-prod) (#4850)#4853
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the HCA DCP ma-prod site configuration to use Google OAuth’s authorization code flow (instead of implicit), mirroring the existing ma-dev approach and deriving the Azul authorize endpoint from the configured DATA_URL.
Changes:
- Switch ma-prod Google OAuth configuration to
OAUTH_FLOW.AUTHORIZATION_CODEwith the newly provisioned prod client ID. - Replace the ma-prod
GOOGLE_PROVIDERconstant withgetGoogleProvider(dataSourceUrl)to deriveauthorizefrom the Azul base URL. - Thread
DATA_URLthroughconfig.ts→getAuthentication(dataSourceUrl)→getGoogleProvider(dataSourceUrl).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| site-config/hca-dcp/ma-prod/config.ts | Passes DATA_URL into getAuthentication so auth endpoints can be derived from the Azul base URL. |
| site-config/hca-dcp/ma-prod/authentication/constants.ts | Introduces getGoogleProvider(dataSourceUrl) using auth-code flow and the new prod Google client ID; derives authorize from Azul. |
| site-config/hca-dcp/ma-prod/authentication/authentication.ts | Updates getAuthentication signature to accept dataSourceUrl and uses getGoogleProvider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8925c55 to
0ab61c8
Compare
NoopDog
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4850
Test plan
🤖 Generated with Claude Code