chore: disable duos access request option for anvil datasets (#4855)#4856
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables the DUOS “Request Access” menu option for AnVIL dataset detail pages by gating the existing DUOS option behind a hardcoded DUOS_ENABLED = false flag, while keeping the DUOS code path intact for easy re-enablement later. This aligns with issue #4855 and preserves existing dbGaP behavior.
Changes:
- Introduced a
DUOS_ENABLEDconstant set tofalseto temporarily disable DUOS request-access options. - Wrapped the DUOS option logic in
getRequestAccessOptions()behindDUOS_ENABLED && duosId. - Left dbGaP option logic unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…4855) with duos disabled, datasets that have only a duos_id no longer render the request access button. the e2e test was picking the first "required" row, which can be duos-only and times out. select a row with a dbgap identifier explicitly so the button is guaranteed to render. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
playwright's hasText evaluates against innertext, which can include surrounding whitespace from the layout around the <p>phs######</p>, so ^phs\d never matches in webkit/firefox. drop the anchor. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…4855) the cc-dev catalog used by anvil e2e returns only three sample datasets to unauthenticated users; none of them have a dbgap identifier. the old "displays request access button" test passed before because the duos-only sample still rendered the button via the duos option. with duos disabled that path is gone, so flip the assertion: confirm the button does not render for the required-access sample. this directly validates the disable behavior in the environment we actually have. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NoopDog
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DUOS_ENABLED = falseconstant ingetRequestAccessOptions()and gates the existing DUOS branch behind it.true.Closes #4855
Test plan
duos_idbut nodbGapId, confirm the "Request Access" dropdown does not show DUOS.duos_idand adbGapId, confirm only the dbGaP option is listed.dbGapId, confirm the dbGaP option still renders as before.🤖 Generated with Claude Code