fix: fix data dictionary table overflow on smaller viewports (#4542) #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes table overflow issues on smaller viewports by improving the data dictionary table rendering. The changes focus on enhancing the "Name" column display and preventing text wrapping issues.
Key changes:
- Added
BasicCellcomponent with no-wrap typography to prevent text overflow - Increased minimum column width from 180px to 240px for better readability
- Enhanced cell rendering with proper typography props configuration
Comments suppressed due to low confidence (1)
app/viewModelBuilders/azul/anvil-cmg/common/dataDictionaryMapper/constants.ts:39
- [nitpick] The parameter name 'cellContext' could be more concise. Consider using 'context' or 'ctx' which is more commonly used in this pattern.
cell: (cellContext) =>
NoopDog
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4542.
Reviewers
@NoopDog.
This pull request updates the
COLUMN_DEFSconfiguration in thedataDictionaryMapper/constants.tsfile to enhance table rendering by introducing a new cell type and adjusting column width.Table rendering improvements:
BasicCellcomponent to the imports to support the new cell type. (app/viewModelBuilders/azul/anvil-cmg/common/dataDictionaryMapper/constants.ts, app/viewModelBuilders/azul/anvil-cmg/common/dataDictionaryMapper/constants.tsR4)namecolumn definition to use theBasicCellcomponent withTypographyPropsfor no-wrap text and dynamic value rendering. (app/viewModelBuilders/azul/anvil-cmg/common/dataDictionaryMapper/constants.ts, app/viewModelBuilders/azul/anvil-cmg/common/dataDictionaryMapper/constants.tsR39-R49)namecolumn from180pxto240pxfor better readability. (app/viewModelBuilders/azul/anvil-cmg/common/dataDictionaryMapper/constants.ts, app/viewModelBuilders/azul/anvil-cmg/common/dataDictionaryMapper/constants.tsR39-R49)