CORE-208: include stack traces in InvalidPfbExceptions#82
Conversation
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 3643595 | Previous: 68dcbd4 | Ratio |
|---|---|---|---|
bio.terra.pfb.LibraryBenchmarks.showNodesMedium |
1933.7613395079065 ops/s |
1859.7220972334542 ops/s |
1.04 |
bio.terra.pfb.LibraryBenchmarks.showNodesSmall |
24861.837612940726 ops/s |
24782.004073882654 ops/s |
1.00 |
bio.terra.pfb.PfbReaderBenchmarks.convertEnum |
5260558.121848094 ops/s |
5256141.2115673125 ops/s |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
calypsomatic
left a comment
calypsomatic
left a comment
There was a problem hiding this comment.
Did we have good security reasons for omitting the stack trace?
We shouldn't bubble up a stack trace to the user. But, that'll be WDS's job to scrub; here in the library we're not doing anything user-facing. We didn't even give WDS the option to hide or display the stack trace! |
3 participants
When reading the nodes of a PFB, we may throw
InvalidPfbException. When we threw that, we omitted the stack trace. This makes debugging inside cWDS pretty hard; we can't see the underlying error that caused the problem.This is a small PR to include the underlying cause in those exceptions.