Skip to content

Conversation

@LizBaldo
Copy link
Collaborator

Reverts #4883

@LizBaldo LizBaldo requested a review from a team as a code owner November 12, 2025 21:38
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 68.49315% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.12%. Comparing base (339b589) to head (57ffbc2).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...kbench/leonardo/monitor/AutoDeleteAppMonitor.scala 66.66% 5 Missing ⚠️
.../leonardo/monitor/LeoPubsubMessageSubscriber.scala 70.58% 5 Missing ⚠️
.../dsde/workbench/leonardo/util/GKEInterpreter.scala 0.00% 5 Missing ⚠️
...ute/dsde/workbench/leonardo/kubernetesModels.scala 0.00% 4 Missing ⚠️
...workbench/leonardo/monitor/LeoMetricsMonitor.scala 0.00% 4 Missing ⚠️
...ch/leonardo/http/BaselineDependenciesBuilder.scala 0.00% 3 Missing ⚠️
...workbench/leonardo/http/service/ProxyService.scala 50.00% 3 Missing ⚠️
...titute/dsde/workbench/leonardo/runtimeModels.scala 0.00% 2 Missing ⚠️
...e/dsde/workbench/leonardo/dao/HttpJupyterDAO.scala 0.00% 2 Missing ⚠️
...te/dsde/workbench/leonardo/dao/HttpWelderDAO.scala 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4885      +/-   ##
===========================================
+ Coverage    72.75%   74.12%   +1.37%     
===========================================
  Files          142      131      -11     
  Lines        11836    11064     -772     
  Branches       951      882      -69     
===========================================
- Hits          8611     8201     -410     
+ Misses        3225     2863     -362     
Files with missing lines Coverage Δ
...tute/dsde/workbench/leonardo/ConfigImplicits.scala 0.00% <ø> (ø)
...institute/dsde/workbench/leonardo/diskModels.scala 33.33% <ø> (ø)
...roadinstitute/dsde/workbench/leonardo/models.scala 50.00% <ø> (+19.23%) ⬆️
...dinstitute/dsde/workbench/leonardo/samModels.scala 0.00% <ø> (ø)
...dinstitute/dsde/workbench/leonardo/LeoLenses.scala 80.00% <100.00%> (+5.00%) ⬆️
...stitute/dsde/workbench/leonardo/LeoPublisher.scala 61.53% <ø> (+1.53%) ⬆️
...dsde/workbench/leonardo/auth/SamAuthProvider.scala 58.19% <ø> (+0.47%) ⬆️
...titute/dsde/workbench/leonardo/config/Config.scala 97.75% <100.00%> (-0.02%) ⬇️
...orkbench/leonardo/config/KubernetesAppConfig.scala 95.00% <ø> (-5.00%) ⬇️
...itute/dsde/workbench/leonardo/dao/HttpSamDAO.scala 22.27% <ø> (-3.14%) ⬇️
... and 45 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339b589...57ffbc2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As good the second time, as the first!

@LizBaldo LizBaldo merged commit 23f272d into develop Nov 13, 2025
22 of 23 checks passed
@LizBaldo LizBaldo deleted the revert-4883-revert-4882-AN-570-azure-code-removal-part-2 branch November 13, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants