Skip to content

[CTM-525] new workbench-libs and update ember#4912

Merged
calypsomatic merged 2 commits into
developfrom
bm/ctm-525_ember-core
Jun 15, 2026
Merged

[CTM-525] new workbench-libs and update ember#4912
calypsomatic merged 2 commits into
developfrom
bm/ctm-525_ember-core

Conversation

@calypsomatic

@calypsomatic calypsomatic commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-525

Summary of changes

Leonardo updated its workbench-libs dependency to the to get http4s upgraded from 1.0.0-M38 to 1.0.0-M45. Since http4s-prometheus-metrics stops publishing at M38, it is pinned at that version with a libraryDependencySchemes override to suppress the eviction error. The new LoggerFactory[F] requirement from ember and http4s M45's Retry middleware was satisfied by injecting a Slf4jFactory-derived implicit at the relevant call sites in production and test code.

Note: I think the codecov failure can be safely ignored - do you agree, reviewer?

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.07%. Comparing base (d018747) to head (177c2c4).

Files with missing lines Patch % Lines
...ch/leonardo/http/BaselineDependenciesBuilder.scala 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4912      +/-   ##
===========================================
- Coverage    74.08%   74.07%   -0.01%     
===========================================
  Files          131      131              
  Lines        11100    11101       +1     
  Branches       902      891      -11     
===========================================
  Hits          8223     8223              
- Misses        2877     2878       +1     
Files with missing lines Coverage Δ
...ch/leonardo/http/BaselineDependenciesBuilder.scala 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d018747...177c2c4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calypsomatic calypsomatic changed the title new workbench-libs and update ember [CTM-525] new workbench-libs and update ember Jun 12, 2026
@calypsomatic calypsomatic marked this pull request as ready for review June 12, 2026 13:32
@calypsomatic calypsomatic requested a review from a team as a code owner June 12, 2026 13:32
@calypsomatic calypsomatic requested a review from aednichols June 12, 2026 13:32

@LizBaldo LizBaldo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree we can ignore the code cov error

@calypsomatic calypsomatic merged commit 82eae55 into develop Jun 15, 2026
14 of 15 checks passed
@calypsomatic calypsomatic deleted the bm/ctm-525_ember-core branch June 15, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants