Bash script for hotswapping leo jar on fiab#766
Merged
akarukappadath merged 8 commits intodevelopfrom Feb 4, 2019
Merged
Conversation
rtitle
reviewed
Feb 4, 2019
| @@ -0,0 +1,17 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Could you add some comments at the top describe what the script is for, what args to pass, etc?
Also maybe some code that prints the usage if the arg isn't specified.
These are just good practices for bash scripts.
Contributor
Author
|
jenkins retest |
Qi77Qi
pushed a commit
that referenced
this pull request
Jun 25, 2019
* starting * still trying * hotswap.sh in automation * changed permissions * cleaned up * comments and error
jchanbroad
pushed a commit
that referenced
this pull request
Jun 27, 2019
* starting * still trying * hotswap.sh in automation * changed permissions * cleaned up * comments and error
jdcanas
pushed a commit
that referenced
this pull request
Jul 10, 2019
* starting * still trying * hotswap.sh in automation * changed permissions * cleaned up * comments and error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote a bash script to perform hotswap of leo jar for a fiab. Run using
./automation/hotswap.sh fiab-your-fiab-name
from leonardo.
Have you read CONTRIBUTING.md lately? If not, do that first.
I, the developer opening this PR, do solemnly pinky swear that:
In all cases: