Skip to content

Add stateful_encoding.proto#443

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
stateful-proto
Feb 13, 2026
Merged

Add stateful_encoding.proto#443
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
stateful-proto

Conversation

@TheSafo
Copy link
Copy Markdown
Contributor

@TheSafo TheSafo commented Feb 12, 2026

What does this PR do?

Defines stateful_encoding.proto (from DataDog/datadog-agent#43321) which is a new experimental protocol we are using to communicate between Agent and Datadog logs intake.

Describe how to test/QA your changes

New protocol has been tested for performance via agent regression tests and correctness via DD intake testing.

Reviewer's Checklist

Reviewers: please see the review guidelines.

Comment thread proto/logsstateful/logsstateful.go
Comment thread proto/logsstateful/logsstateful.go
@TheSafo TheSafo requested a review from pgimalac February 12, 2026 17:34
Comment thread tasks/codegen.py
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try benchmarking vtproto vs google.golang.org/protobuf (+ opaque API) ?
I'm considering trying to unify protobuf libraries used by the agent so that would be very interesting to me

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've seen significant (~2x) CPU time savings when testing via lading-based performance tests on marshal/size operations.

@TheSafo
Copy link
Copy Markdown
Contributor Author

TheSafo commented Feb 13, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Feb 13, 2026

View all feedbacks in Devflow UI.

2026-02-13 20:06:30 UTC ℹ️ Start processing command /merge


2026-02-13 20:06:34 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).


2026-02-13 20:08:51 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants