callback fails without config file

[dobber]

I would like to commit the datadog_callback.py into my repo and use it by default on my CI servers. I also use my playbooks with my local installations (vagrant) and share it with all the devs in the company, where I don't need to constantly spam datadog with events. Is it possible to setup the datadog_callback.py not to be called if there is no datadog_callback.yml file configured? Idealy the datadog_callback.yml will not be committed to the repo.

[olivielpeau]

Hi @dobber, thanks for the feedback!

Ansible always calls the classes defined in the .py files of its callback_plugins/ directory. That said we could add some conditional logic in the callback to send events and metrics only when the datadog_callback.yml file is found.

If we do this we should also print a warning when the file doesn't exist so that it's clear that in this case the callback won't send data at all.

Would this behavior fit your use case?

Feel free to open a PR implementing this if you have time. In all cases thanks again for your feedback!

[irabinovitch]

Hi @dobber, looking forward to your feedback regarding @olivielpeau 's questions.

[dobber]

Yes, it would be best to print a warning, saying that the callback is disabled, but still continue execution.
I've opened a PR, but it's kind of outdated already

[irabinovitch]

@dobber Thanks. Can you add a link to the PR?

[olivielpeau]

@irabinovitch The related PR is #5 (linked above), it's planned for 1.1.

@dobber Sorry for the delay here, if you have time could you rebase your PR on top of master? Otherwise I'll do it for the next release.

[irabinovitch]

@olivielpeau do we have a timeline for 1.1?

[szponek]

Maybe we could get #5 and #25 combined somehow?

[hush-hush]

This was fixed by merging #25 (thanks to @szponek).