Avoid traceback when using ansible >=2.4 with '-i' option #27
Conversation
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
LGTM! (only one small nit)
Thanks for fixing this 👍
datadog_callback.py
Outdated
|
|
||
| # inventory is a comma separated host list | ||
| if isinstance(inventory, list): | ||
| inventory = ','.join(inventory) |
There was a problem hiding this comment.
nit: instead of going from a list to a string (and then back to a list below with inventory.split(',') ; how about normalizing to a listdirectly? i.e.:
if isinstance(inventory, basestring):
inventory = inventory.split(',')Or am I missing something? 😃
There was a problem hiding this comment.
Actually we can have multiple item in the list each containing coma:
ex: -i "web,db" -i "worker,test,admin"
will produce:
inventory = ["web,db", "worker,test,admin"]So we need to either join the item in the list, or split the item and go over them after to split again.
There was a problem hiding this comment.
oh, ok, makes sense then, thanks!
It's a bit counter-intuitive IMO, might be worth adding a comment to explain this behavior :)
Anyway, feel free to merge 👍
Starting from ansible 2.4 command line options are now received as a list. In ansible >=2.4 it's now technically possible to specify multiple times the '-i' option (even if the documentation say otherwise). This commit merge all host while removing any extra comas.
hush-hush
force-pushed
the
maxime/fix-inventory
branch
from
56ee64c to
862b888
Compare
Changes
Starting from ansible 2.4 command line options are now received as a
list. In ansible >=2.4 it's now technically possible to specify multiple
times the '-i' option (even if the documentation say otherwise).
This commit merge all host while removing any extra comas.
This was reported on #23.