add hook to handle incompatibilities between ansible 2.7 and ansible 2.8 #47
Conversation
dabcoder
left a comment
dabcoder
left a comment
There was a problem hiding this comment.
Thanks for taking care of this, much appreciated. Left a quick note.
datadog_callback.py
Outdated
| import logging | ||
| import os | ||
| import time | ||
| from packaging import version |
There was a problem hiding this comment.
This resulted in having the callback ignored if packaging is not installed (with pip) when I tested this.
Do you think we should include it in the list of requirements then (with datadogpy and pyyaml)?
There was a problem hiding this comment.
Yeah, it should be there. Just pushed a commit to put it in the README.
hush-hush
left a comment
hush-hush
left a comment
There was a problem hiding this comment.
Hi @rsdcobalt, thanks for the PR !
I added a few comments, tell me what you think.
datadog_callback.py
Outdated
| from ansible.plugins.callback import CallbackBase | ||
| from __main__ import cli | ||
|
|
||
| ANSIBLE_NEW = False |
There was a problem hiding this comment.
Could you rename this to ANSIBLE_ABOVE_28 or something similar as it will not always be the "new" version ?
datadog_callback.py
Outdated
| self._playbook_name, _ = os.path.splitext( | ||
| os.path.basename(playbook_file_name)) | ||
| if isinstance(inventory, list): | ||
| if isinstance(inventory, list) or isinstance(inventory, tuple): |
There was a problem hiding this comment.
This could be on condition: if isinstance(inventory, (list, tuple)):
datadog_callback.py
Outdated
| import logging | ||
| import os | ||
| import time | ||
| from packaging import version |
There was a problem hiding this comment.
Could you move this line within the try/catch line 9 and update the error message line 32 ?
|
@hush-hush yeah, those make sense. I just committed the changes. |
|
Thanks a lot for this PR @rsdcobalt, merging today ! |
3 participants
There have been some changes with ansible 2.8 that aren't compatible with 2.7. I've added a check to handle those differences.