Format `datadog.conf` with the INI format instead of YAML

[olivielpeau]

See example in DataDog/dd-agent#3227

The datadog.conf file should be formatted as an INI file instead of YAML here: https://github.com/DataDog/ansible-datadog/blob/1.2.0/templates/datadog.conf.j2#L17

cc @pahaz who reported the issue in the linked issue

[rkonrath]

Hi,
I had the same problem with this template:
https://github.com/DataDog/ansible-datadog/blob/master/templates/checks.yaml.j2

So, I fixed it temporary:
-{{ datadog_checks[item] | to_nice_yaml }}
+{{ datadog_checks[item] | to_json | from_json | to_nice_yaml }}

[pahaz]

Any news?

[wawrzek]

I couldn't define hostname: {{ ansible_hostname }} in config. It might be related to Ansible bug (ansible/ansible#20253).

[mliljedahl]

A workaround is to remove the spaces between the commas when for example defining tags.

Example from playbook

- hosts: webservers
  become: true
  roles:
    - role: datadog
      datadog_api_key: "{{ datadog_api_key }}"
      datadog_config:
        tags: "environment:production,group:webservers,datacenter:europe,provider:gce"

[wawrzek]

@mliljedahl - good spot, but it doesn't work for everything e.g. hostname

[rkonrath]

@wawrzek
For datadog.conf try to change the template file:

--{{ datadog_config | to_nice_yaml }}
++{{ datadog_config | to_json | from_json | to_nice_yaml }}

https://github.com/DataDog/ansible-datadog/blob/master/templates/datadog.conf.j2#L17

and maybe you gonna need change this line to in case to use keyvals as variable:
--{{ keyvals | to_nice_yaml }}
++{{ keyvals | to_json | from_json | to_nice_yaml }}
https://github.com/DataDog/ansible-datadog/blob/master/templates/datadog.conf.j2#L17

[wawrzek]

@rkonrath - thanks I already did.

[olivielpeau]

Thanks for the feedback, I've opened #59 which should address the formatting issue on the datadog.conf file.

The issues on the check config files don't seem directly related though (since, unlike datadog.conf, check config files should be yaml-formatted), if you're still experiencing these issues could you open a separate issue so that we can discuss it there?