Refactor integration-related tasks #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the code tidier and user-facing messages prettier. It also ensures that Windows tasks will only be imported on Windows, thus making the ansible.windows collection optional.
chouetz
requested changes
May 15, 2023
Member
chouetz
left a comment
chouetz
left a comment
There was a problem hiding this comment.
I guess at least the correction on calling the macos file on top condition must be changed, thanks in advance
tasks/integration/windows.yml
Outdated
| - name: Set Agent user for integration commmand | ||
| set_fact: | ||
| integration_command_user: "{{ integration_command_user_windows }}" | ||
| when: ansible_facts.os_family == "Windows" |
Member
There was a problem hiding this comment.
This (and the other when conditions mentioning "Windows") are unnecessary as already checked to call this file, correct?
Contributor
Author
There was a problem hiding this comment.
Yes, I forgot to remove the conditions from this file, thanks for pointing it out!
Co-authored-by: Nicolas Schweitzer <nicolas.schweitzer@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the code tidier and user-facing messages prettier. It also ensures that Windows tasks will only be imported on Windows, thus making the ansible.windows collection optional.
This fixes #450.