Add support for compliance_config #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkabrda
suggested changes
Jun 6, 2023
Contributor
bkabrda
left a comment
bkabrda
left a comment
There was a problem hiding this comment.
Hi 👋 thanks for the PR. The functionality itself looks fine, but could you please document this new value in the README.md section here: https://github.com/DataDog/ansible-datadog#system-probe to make sure it's discoverable? Thanks!
Contributor
Author
Added, let me know if you need something else |
bkabrda
suggested changes
Jun 7, 2023
Contributor
bkabrda
left a comment
bkabrda
left a comment
There was a problem hiding this comment.
👋 just one minor suggestion to address, then I can approve and merge. Thanks!
Co-authored-by: Slavek Kabrda <slavek.kabrda@gmail.com>
alai97
approved these changes
Jun 7, 2023
Contributor
alai97
left a comment
alai97
left a comment
There was a problem hiding this comment.
Looks good, one suggestion!
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
bkabrda
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for compliance_config in security-agent.yaml.j2.
This entry is present in https://github.com/DataDog/datadog-agent/blob/main/pkg/config/config_template.yaml#L1581-L1611