[fixme] #2883 conflicts with staging-30

developer-extension/src/panel/components/tabs/eventsTab/copyEvent.spec.ts

@@ -1,4 +1,3 @@
-import { isIE } from '@datadog/browser-core'
 import type { TelemetryEvent } from '../../../../../../packages/core/src/domain/telemetry'
 import type { LogsEvent } from '../../../../../../packages/logs/src/logsEvent.types'
 import type { RumEvent } from '../../../../../../packages/rum-core/src/rumEvent.types'
@@ -14,11 +13,6 @@ const LOG_EVENT = {
 } as LogsEvent
 
 describe('getIntakeUrlForEvent', () => {
-  beforeEach(() => {
-    if (isIE()) {
-      pending('IE not supported')
-    }
-  })
   it('should return undefined when RUM is not present', () => {
     expect(getIntakeUrlForEvent({} as any, RUM_ERROR_EVENT)).toBeUndefined()
   })

developer-extension/src/panel/hooks/useEvents/eventFilters.spec.ts

@@ -1,7 +1,7 @@
-import { isIE, isSafari } from '@datadog/browser-core'
+import { isSafari } from '@datadog/browser-core'
 import { parseQuery, matchWithWildcard } from './eventFilters'
 
-if (!isIE() && !isSafari()) {
+if (!isSafari()) {
   describe('parseQuery', () => {
     it('return a simple field', () => {
       expect(parseQuery('foo:bar')).toEqual([['foo', 'bar']])

packages/core/src/browser/fetchObservable.spec.ts

@@ -1,6 +1,5 @@
 import type { MockFetch, MockFetchManager } from '../../test'
 import { registerCleanupTask, mockFetch } from '../../test'
-import { isIE } from '../tools/utils/browserDetection'
 import type { Subscription } from '../tools/observable'
 import type { FetchResolveContext, FetchContext } from './fetchObservable'
 import { initFetchObservable } from './fetchObservable'
@@ -17,9 +16,6 @@ describe('fetch proxy', () => {
   let fetch: MockFetch
 
   beforeEach(() => {
-    if (isIE()) {
-      pending('no fetch support')
-    }
     mockFetchManager = mockFetch()
     originalMockFetch = window.fetch
 

packages/core/src/browser/xhrObservable.spec.ts

@@ -1,6 +1,5 @@
 import type { Configuration } from '../domain/configuration'
 import { withXhr, mockXhr } from '../../test'
-import { isIE } from '../tools/utils/browserDetection'
 import type { Subscription } from '../tools/observable'
 import type { XhrCompleteContext, XhrContext } from './xhrObservable'
 import { initXhrObservable } from './xhrObservable'
@@ -346,9 +345,6 @@ describe('xhr observable', () => {
   })
 
   it('should track request to URL object', (done) => {
-    if (isIE()) {
-      pending('IE not supported')
-    }
     withXhr({
       setup(xhr) {
         xhr.open('GET', new URL('http://example.com/path'))

packages/core/src/domain/console/consoleObservable.spec.ts

@@ -1,5 +1,4 @@
 /* eslint-disable no-console */
-import { isIE } from '../../tools/utils/browserDetection'
 import { ConsoleApiName } from '../../tools/display'
 import type { Subscription } from '../../tools/observable'
 import type { ConsoleLog } from './consoleObservable'
@@ -104,11 +103,7 @@ describe('console error observable', () => {
   it('should extract stack from first error', () => {
     console.error(new TypeError('foo'), new TypeError('bar'))
     const stack = (notifyLog.calls.mostRecent().args[0] as ConsoleLog).stack
-    if (!isIE()) {
-      expect(stack).toMatch(/^TypeError: foo\s+at/)
-    } else {
-      expect(stack).toContain('TypeError: foo')
-    }
+    expect(stack).toContain('TypeError: foo')
   })
 
   it('should retrieve fingerprint from error', () => {

packages/core/src/domain/error/trackRuntimeError.spec.ts

@@ -1,6 +1,5 @@
 import { disableJasmineUncaughtExceptionTracking, collectAsyncCalls } from '../../../test'
 import { Observable } from '../../tools/observable'
-import { isIE } from '../../tools/utils/browserDetection'
 import type { UnhandledErrorCallback } from './trackRuntimeError'
 import { instrumentOnError, instrumentUnhandledRejection, trackRuntimeError } from './trackRuntimeError'
 import type { RawError } from './error.types'
@@ -49,9 +48,6 @@ describe('trackRuntimeError', () => {
   })
 
   it('should collect unhandled rejection', (done) => {
-    if (isIE()) {
-      pending('no promise support')
-    }
     disableJasmineUncaughtExceptionTracking()
 
     setTimeout(() => {

packages/core/src/domain/session/sessionManager.spec.ts

@@ -9,7 +9,6 @@ import {
 import type { Clock } from '../../../test'
 import { getCookie, setCookie } from '../../browser/cookie'
 import type { RelativeTime } from '../../tools/utils/timeUtils'
-import { isIE } from '../../tools/utils/browserDetection'
 import { DOM_EVENT } from '../../browser/addEventListener'
 import { ONE_HOUR, ONE_SECOND } from '../../tools/utils/timeUtils'
 import type { Configuration } from '../configuration'
@@ -92,9 +91,6 @@ describe('startSessionManager', () => {
   }
 
   beforeEach(() => {
-    if (isIE()) {
-      pending('no full rum support')
-    }
     clock = mockClock()
 
     registerCleanupTask(() => {

packages/core/src/tools/readBytesFromStream.spec.ts

@@ -1,4 +1,3 @@
-import { isIE } from './utils/browserDetection'
 import { readBytesFromStream } from './readBytesFromStream'
 
 describe('readBytesFromStream', () => {
@@ -7,9 +6,6 @@ describe('readBytesFromStream', () => {
   let stream: ReadableStream
 
   beforeEach(() => {
-    if (isIE()) {
-      pending('no ReadableStream support')
-    }
     beenCalled = false
     stream = new ReadableStream({
       pull: (controller) => {

packages/core/src/tools/serialisation/sanitize.spec.ts

@@ -1,4 +1,3 @@
-import { isIE } from '../utils/browserDetection'
 import { display } from '../display'
 import { createNewEvent } from '../../../test'
 import { sanitize } from './sanitize'
@@ -30,12 +29,7 @@ describe('sanitize', () => {
       function testFunction() {
         return true
       }
-      if (isIE()) {
-        // IE does not provide access to function name
-        expect(sanitize(testFunction)).toBe('[Function] unknown')
-      } else {
-        expect(sanitize(testFunction)).toBe('[Function] testFunction')
-      }
+      expect(sanitize(testFunction)).toBe('[Function] testFunction')
     })
 
     it('should handle bigint', () => {
@@ -102,19 +96,10 @@ describe('sanitize', () => {
         ['a', 13],
         ['b', 37],
       ])
-      if (isIE()) {
-        // IE does not distinguish maps, weakmaps, sets... from generic objects
-        expect(sanitize(map)).toEqual({})
-      } else {
-        expect(sanitize(map)).toBe('[Map]')
-      }
+      expect(sanitize(map)).toBe('[Map]')
     })
 
     it('should survive when toStringTag throws', () => {
-      if (isIE()) {
-        pending('IE does not support Symbols')
-      }
-
       class CannotSerialize {
         get [Symbol.toStringTag]() {
           throw Error('Cannot serialize')
@@ -229,12 +214,7 @@ describe('sanitize', () => {
       const obj = { b: 42, toJSON: faulty }
 
       // Since toJSON throws, sanitize falls back to serialize property by property
-      if (isIE()) {
-        // IE does not provide access to function name
-        expect(sanitize(obj)).toEqual({ b: 42, toJSON: '[Function] unknown' })
-      } else {
-        expect(sanitize(obj)).toEqual({ b: 42, toJSON: '[Function] faulty' })
-      }
+      expect(sanitize(obj)).toEqual({ b: 42, toJSON: '[Function] faulty' })
     })
   })
 

packages/core/test/leakDetection.ts

@@ -1,5 +1,4 @@
 import { display } from '../src/tools/display'
-import { isIE } from '../src/tools/utils/browserDetection'
 import { getCurrentJasmineSpec } from './getCurrentJasmineSpec'
 
 let originalAddEventListener: typeof EventTarget.prototype.addEventListener
@@ -9,9 +8,6 @@ let wrappedListeners: {
 }
 
 export function startLeakDetection() {
-  if (isIE()) {
-    return
-  }
   wrappedListeners = {}
 
   // eslint-disable-next-line @typescript-eslint/unbound-method
@@ -35,9 +31,6 @@ export function startLeakDetection() {
 }
 
 export function stopLeakDetection() {
-  if (isIE()) {
-    return
-  }
   EventTarget.prototype.addEventListener = originalAddEventListener
   EventTarget.prototype.removeEventListener = originalRemoveEventListener
   wrappedListeners = {}

packages/logs/BROWSER_SUPPORT.md

@@ -1,16 +1,16 @@
 # Browser Support
 
-| Feature        | Chrome | Firefox | Safari | Edge | Chrome Android | Safari iOS | IE11 | < IE11 | Opera |
-| -------------- | ------ | ------- | ------ | ---- | -------------- | ---------- | ---- | ------ | ----- |
-| loading        | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
-| init           | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
-| global context | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
-| logs request   | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
-| flush on hide  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌   | ❌     | ✅    |
-| console error  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
-| network error  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
-| runtime error  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
-| CSP violation  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌   | ❌     | ✅    |
-| reports        | ✅     | ❌      | ❌     | ✅   | ✅             | ❌         | ❌   | ❌     | ✅    |
-| custom logger  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
-| handler        | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ✅   | ❌     | ✅    |
+| Feature        | Chrome | Firefox | Safari | Edge | Chrome Android | Safari iOS | IE  | Opera |
+| -------------- | ------ | ------- | ------ | ---- | -------------- | ---------- | --- | ----- |
+| loading        | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| init           | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| global context | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| logs request   | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| flush on hide  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| console error  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| network error  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| runtime error  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| CSP violation  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| reports        | ✅     | ❌      | ❌     | ✅   | ✅             | ❌         | ❌  | ✅    |
+| custom logger  | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |
+| handler        | ✅     | ✅      | ✅     | ✅   | ✅             | ✅         | ❌  | ✅    |

packages/logs/src/boot/preStartLogs.spec.ts

@@ -5,7 +5,6 @@ import {
   TrackingConsent,
   createTrackingConsentState,
   display,
-  isIE,
   resetFetchObservable,
 } from '@datadog/browser-core'
 import type { CommonContext } from '../rawLogsEvent.types'
@@ -217,12 +216,6 @@ describe('preStartLogs', () => {
     })
 
     describe('basic methods instrumentation', () => {
-      beforeEach(() => {
-        if (isIE()) {
-          pending('No support for IE')
-        }
-      })
-
       it('should instrument fetch even if tracking consent is not granted', () => {
         const originalFetch = window.fetch
 

packages/logs/src/domain/networkError/networkErrorCollection.spec.ts

@@ -1,4 +1,4 @@
-import { isIE, ErrorSource } from '@datadog/browser-core'
+import { ErrorSource } from '@datadog/browser-core'
 import type { MockFetch, MockFetchManager } from '@datadog/browser-core/test'
 import { SPEC_ENDPOINTS, MockResponse, mockFetch, registerCleanupTask } from '@datadog/browser-core/test'
 import type { RawNetworkLogsEvent } from '../../rawLogsEvent.types'
@@ -45,9 +45,6 @@ describe('network error collection', () => {
   }
 
   beforeEach(() => {
-    if (isIE()) {
-      pending('no fetch support')
-    }
     rawLogsEvents = []
     lifeCycle = new LifeCycle()
     lifeCycle.subscribe(LifeCycleEventType.RAW_LOG_COLLECTED, (rawLogsEvent) =>
@@ -189,10 +186,6 @@ describe('computeFetchResponseText', () => {
   let onunhandledrejectionSpy: jasmine.Spy
 
   beforeEach(() => {
-    if (isIE()) {
-      pending('IE does not support the fetch API')
-    }
-
     onunhandledrejectionSpy = jasmine.createSpy()
     window.onunhandledrejection = onunhandledrejectionSpy
 

packages/rum-core/src/boot/preStartRum.spec.ts

@@ -12,7 +12,6 @@ import {
   ExperimentalFeature,
   resetExperimentalFeatures,
   resetFetchObservable,
-  isIE,
 } from '@datadog/browser-core'
 import type { Clock } from '@datadog/browser-core/test'
 import {
@@ -712,12 +711,6 @@ describe('preStartRum', () => {
     })
 
     describe('basic methods instrumentation', () => {
-      beforeEach(() => {
-        if (isIE()) {
-          pending('No support for IE')
-        }
-      })
-
       it('should instrument fetch even if tracking consent is not granted', () => {
         const originalFetch = window.fetch
 

packages/rum-core/src/boot/startRum.spec.ts

@@ -5,7 +5,6 @@ import {
   ONE_SECOND,
   findLast,
   noop,
-  isIE,
   relativeNow,
   createIdentityEncoder,
   createCustomerDataTracker,
@@ -88,10 +87,6 @@ describe('rum session', () => {
   let serverRumEvents: RumEvent[]
 
   beforeEach(() => {
-    if (isIE()) {
-      pending('no full rum support')
-    }
-
     setupBuilder = setup().beforeBuild(
       ({
         location,
@@ -146,9 +141,6 @@ describe('rum session keep alive', () => {
   let serverRumEvents: RumEvent[]
 
   beforeEach(() => {
-    if (isIE()) {
-      pending('no full rum support')
-    }
     sessionManager = createRumSessionManagerMock().setId('1234')
     setupBuilder = setup()
       .withFakeClock()

packages/rum-core/src/browser/domMutationObservable.spec.ts

@@ -1,4 +1,3 @@
-import { isIE } from '@datadog/browser-core'
 import type { MockZoneJs } from '@datadog/browser-core/test'
 import { registerCleanupTask, mockZoneJs } from '@datadog/browser-core/test'
 import { createDOMMutationObservable, getMutationObserverConstructor } from './domMutationObservable'
@@ -8,12 +7,6 @@ import { createDOMMutationObservable, getMutationObserverConstructor } from './d
 const DOM_MUTATION_OBSERVABLE_DURATION = 16
 
 describe('domMutationObservable', () => {
-  beforeEach(() => {
-    if (isIE()) {
-      pending('dom mutation not available')
-    }
-  })
-
   function domMutationSpec(mutate: (root: HTMLElement) => void, { expectedMutations }: { expectedMutations: number }) {
     return (done: DoneFn) => {
       const root = document.createElement('div')
@@ -113,10 +106,6 @@ describe('domMutationObservable', () => {
     const OriginalMutationObserverConstructor = window.MutationObserver
 
     beforeEach(() => {
-      if (isIE()) {
-        pending('dom mutation not available')
-      }
-
       zoneJs = mockZoneJs()
 
       registerCleanupTask(() => {