Skip to content

🔥 Remove old cookie migration#4198

Merged
thomas-lebeau merged 1 commit intov7from
thomas.lebeau/remove-old-cookie-migration
Feb 18, 2026
Merged

🔥 Remove old cookie migration#4198
thomas-lebeau merged 1 commit intov7from
thomas.lebeau/remove-old-cookie-migration

Conversation

@thomas-lebeau
Copy link
Copy Markdown
Collaborator

Motivation

The old cookie migration code (tryOldCookiesMigration) handled upgrading from a legacy cookie format (_dd, _dd_r, _dd_l) to the current unified _dd_s cookie. This migration has been in place long enough that any users still on the old format have either upgraded or are no longer active. For v7, this legacy compatibility code is no longer needed.

Changes

  • Remove oldCookiesMigration.ts and its spec file (oldCookiesMigration.spec.ts) from packages/core
  • Remove the tryOldCookiesMigration call from initCookieStrategy in sessionInCookie.ts
  • The old cookie names _dd, _dd_r, and _dd_l are no longer read or migrated

Test instructions

  1. Verify unit tests pass: yarn test:unit
  2. Confirm no references to tryOldCookiesMigration or oldCookiesMigration remain in the codebase
  3. Verify session initialization works correctly without the migration step

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

- Remove tryOldCookiesMigration and its tests
- Remove migration call from initCookieStrategy
- Old cookie format (_dd, _dd_r, _dd_l) is no longer supported
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Feb 17, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.25 KiB 172.01 KiB -246 B -0.14%
Rum Profiler 4.29 KiB 4.29 KiB 0 B 0.00%
Rum Recorder 24.71 KiB 24.71 KiB 0 B 0.00%
Logs 56.93 KiB 56.69 KiB -246 B -0.42%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 128.75 KiB 128.51 KiB -246 B -0.19%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance

Pending...

🧠 Memory Performance

Pending...

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Feb 17, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 80.18%
Overall Coverage: 77.12% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2b1b5d8 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@thomas-lebeau thomas-lebeau changed the base branch from main to v7 February 17, 2026 15:56
@thomas-lebeau thomas-lebeau marked this pull request as ready for review February 18, 2026 06:48
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner February 18, 2026 06:48
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b1b5d841f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/domain/session/storeStrategies/sessionInCookie.ts
@thomas-lebeau thomas-lebeau merged commit c2bba2d into v7 Feb 18, 2026
22 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/remove-old-cookie-migration branch February 18, 2026 08:27
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants