✅ allow running e2e tests offline#4336
Merged
BenoitZugmeyer merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
When no network interface is available (e.g. offline dev environment), `getIp()` would throw due to the non-null assertion. Fall back to `127.0.0.1` instead. Similarly, forwarding intake requests to Datadog may fail when offline; log the error and resolve gracefully so the test suite can continue.
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 02e76a0 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
This helps understanding why the e2e tests are failing when the nextjs test app isn't installed properly.
thomas-lebeau
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Running E2E tests in an offline environment (e.g. on an airplane or without network access) would fail immediately — once because
getIp()crashed when no network interface was found, and again because the intake server would reject connections when trying to forward requests to Datadog.Changes
127.0.0.1ingetIp()when no external IPv4 interface is available, instead of throwingTest instructions
Run the E2E test suite while offline (or with the network interface disabled) and verify the tests start up correctly instead of crashing at initialization.
Checklist