👷 NextJS- Make NextJS plugin private#4346
Merged
BeltranBulbarellaDD merged 4 commits intomainfrom Mar 17, 2026
Merged
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: db6d84e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BenoitZugmeyer
approved these changes
Mar 17, 2026
packages/rum-nextjs/package.json
Outdated
Comment on lines
+13
to
+14
| "@datadog/browser-core": "*", | ||
| "@datadog/browser-rum-core": "*" |
Collaborator
There was a problem hiding this comment.
❓ question: Why this change?
Contributor
Author
There was a problem hiding this comment.
IMO Simplicity. We don't need a version since checkPackageDependencyVersions will early return on private packages, so we just resolve to the workspace version.
amortemousque
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Like PR, makes package private so as to not release it.
Changes
Test instructions
Checklist