Skip to content

👷 NextJS- Make NextJS plugin private#4346

Merged
BeltranBulbarellaDD merged 4 commits intomainfrom
make-nextjs-private
Mar 17, 2026
Merged

👷 NextJS- Make NextJS plugin private#4346
BeltranBulbarellaDD merged 4 commits intomainfrom
make-nextjs-private

Conversation

@BeltranBulbarellaDD
Copy link
Copy Markdown
Contributor

@BeltranBulbarellaDD BeltranBulbarellaDD commented Mar 17, 2026

Motivation

Like PR, makes package private so as to not release it.

Changes

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@BeltranBulbarellaDD BeltranBulbarellaDD changed the title 👷 NextJS- Make plugin private 👷 NextJS- Make NextJS plugin private Mar 17, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Mar 17, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 175.02 KiB 175.02 KiB 0 B 0.00%
Rum Profiler 6.16 KiB 6.16 KiB 0 B 0.00%
Rum Recorder 27.46 KiB 27.46 KiB 0 B 0.00%
Logs 56.80 KiB 56.80 KiB 0 B 0.00%
Rum Slim 130.66 KiB 130.66 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0055 0.0041 -25.45%
RUM - add action 0.0194 0.0134 -30.93%
RUM - add error 0.0185 0.0133 -28.11%
RUM - add timing 0.0078 0.0032 -58.97%
RUM - start view 0.0173 0.0143 -17.34%
RUM - start/stop session replay recording 0.0011 0.0007 -36.36%
Logs - log message 0.0223 0.0167 -25.11%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 26.31 KiB 26.86 KiB +560 B
RUM - add action 51.00 KiB 51.35 KiB +358 B
RUM - add error 55.49 KiB 55.22 KiB -278 B
RUM - add timing 25.96 KiB 27.34 KiB +1.38 KiB
RUM - start/stop session replay recording 25.88 KiB 26.30 KiB +424 B
RUM - start view 461.79 KiB 462.89 KiB +1.10 KiB
Logs - log message 45.23 KiB 44.11 KiB -1.12 KiB

🔗 RealWorld

@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 bot commented Mar 17, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.25% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: db6d84e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@BeltranBulbarellaDD BeltranBulbarellaDD marked this pull request as ready for review March 17, 2026 13:29
@BeltranBulbarellaDD BeltranBulbarellaDD requested a review from a team as a code owner March 17, 2026 13:29
Comment on lines +13 to +14
"@datadog/browser-core": "*",
"@datadog/browser-rum-core": "*"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ question: ‏Why this change?

Copy link
Copy Markdown
Contributor Author

@BeltranBulbarellaDD BeltranBulbarellaDD Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO Simplicity. We don't need a version since checkPackageDependencyVersions will early return on private packages, so we just resolve to the workspace version.

@BeltranBulbarellaDD BeltranBulbarellaDD merged commit 8349a59 into main Mar 17, 2026
21 checks passed
@BeltranBulbarellaDD BeltranBulbarellaDD deleted the make-nextjs-private branch March 17, 2026 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants