Skip to content

[PANA-6072] follow up review #4211#4367

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
luiz.barreto/PANA-6072-action-mgmt-browser-sdk-po-c-for-event-path-selector-collection-update__follow-up
Mar 26, 2026
Merged

[PANA-6072] follow up review #4211#4367
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
luiz.barreto/PANA-6072-action-mgmt-browser-sdk-po-c-for-event-path-selector-collection-update__follow-up

Conversation

@LFBarreto
Copy link
Copy Markdown
Collaborator

@LFBarreto LFBarreto commented Mar 23, 2026

Motivation

PANA-6072

Changes

This addresses review comments on #4211
No major changes mostly test.

Test instructions

  • CI should be green

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (BenoitZugmeyer)[https://github.com/BenoitZugmeyer]
@LFBarreto
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@datadog-prod-us1-4
Copy link
Copy Markdown

datadog-prod-us1-4 bot commented Mar 23, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 50.00%
Overall Coverage: 77.29% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 835a323 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@LFBarreto LFBarreto force-pushed the luiz.barreto/PANA-6072-action-mgmt-browser-sdk-po-c-for-event-path-selector-collection-update__follow-up branch from c372384 to d49b54b Compare March 23, 2026 13:28
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Mar 23, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 176.52 KiB 176.52 KiB 0 B 0.00%
Rum Profiler 6.16 KiB 6.16 KiB 0 B 0.00%
Rum Recorder 27.46 KiB 27.46 KiB 0 B 0.00%
Logs 56.85 KiB 56.85 KiB 0 B 0.00%
Rum Slim 132.16 KiB 132.16 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0039 0.0054 +38.46%
RUM - add action 0.0135 0.0149 +10.37%
RUM - add error 0.0126 0.0152 +20.63%
RUM - add timing 0.0025 0.0031 +24.00%
RUM - start view 0.0117 0.0177 +51.28%
RUM - start/stop session replay recording 0.0007 0.0007 0.00%
Logs - log message 0.0139 0.0158 +13.67%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 26.85 KiB 27.43 KiB +593 B
RUM - add action 52.83 KiB 101.98 KiB +49.15 KiB
RUM - add timing 26.89 KiB 26.07 KiB -844 B
RUM - add error 56.41 KiB 107.08 KiB +50.68 KiB
RUM - start/stop session replay recording 25.68 KiB 25.02 KiB -677 B
RUM - start view 461.51 KiB 476.12 KiB +14.61 KiB
Logs - log message 44.31 KiB 44.97 KiB +677 B

🔗 RealWorld

@LFBarreto LFBarreto marked this pull request as ready for review March 23, 2026 14:27
@LFBarreto LFBarreto requested a review from a team as a code owner March 23, 2026 14:27
@LFBarreto LFBarreto changed the title [PANA-6072] follow up review ##4211 [PANA-6072] follow up review #4211 Mar 23, 2026
@LFBarreto LFBarreto force-pushed the luiz.barreto/PANA-6072-action-mgmt-browser-sdk-po-c-for-event-path-selector-collection-update__follow-up branch from 9ab7829 to 835a323 Compare March 25, 2026 16:24
@LFBarreto
Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 26, 2026

View all feedbacks in Devflow UI.

2026-03-26 08:32:36 UTC ℹ️ Start processing command /merge


2026-03-26 08:32:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-03-26 09:03:56 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 2b00a84 into main Mar 26, 2026
21 of 22 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the luiz.barreto/PANA-6072-action-mgmt-browser-sdk-po-c-for-event-path-selector-collection-update__follow-up branch March 26, 2026 09:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants