Skip to content

💥 Remove deprecated strategy from plugin API#4382

Merged
thomas-lebeau merged 1 commit intov7from
thomas.lebeau/v7-remove-strategy-from-plugins
Mar 25, 2026
Merged

💥 Remove deprecated strategy from plugin API#4382
thomas-lebeau merged 1 commit intov7from
thomas.lebeau/v7-remove-strategy-from-plugins

Conversation

@thomas-lebeau
Copy link
Copy Markdown
Collaborator

Motivation

Simplification and code removal. The strategy property on OnRumStartOptions was deprecated in favor of addEvent. Removing it for v7.

Customers using rum-react or custom plugins that rely on strategy will need to upgrade to use addEvent instead. This API may be used by customers in the wild, but it is unsupported.

Changes

  • Remove strategy property from OnRumStartOptions interface
  • Remove Strategy type import from plugins.ts
  • Stop passing strategy in the callPluginsMethod call in rumPublicApi.ts

Test instructions

  • yarn typecheck should pass
  • Verify no remaining references to strategy in the plugin API

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@thomas-lebeau thomas-lebeau requested a review from a team as a code owner March 24, 2026 16:02
@thomas-lebeau thomas-lebeau marked this pull request as draft March 24, 2026 16:05
@thomas-lebeau
Copy link
Copy Markdown
Collaborator Author

/trigger-ci

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-03-24 18:22:23 UTC ℹ️ Start processing command /trigger-ci
If you need support, contact us on Slack #devflow!


2026-03-24 18:22:39 UTC ℹ️ Branch synced on Gitlab

Branch thomas.lebeau/v7-remove-strategy-from-plugins was out-of-sync on Gitlab - it has been resynced

If you need support, contact us on Slack #devflow!


2026-03-24 18:23:44 UTC 🚨 Devflow

POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/browser-sdk/pipeline: 400 {message: {base: [Reference not found]}}

Details
child workflow execution error (type: devtools.Devtools_TriggerCiFromPr, workflowID: bb5fa090-3533-445d-8455-159d0b1986e9_32, runID: 019d2115-640f-7afc-b47b-ffbe987ec027, initiatedEventID: 32, startedEventID: 33): child workflow execution error (type: devtools.Devtools_TriggerCi, workflowID: 019d2115-640f-7afc-b47b-ffbe987ec027_14, runID: 019d2115-6803-73b7-90b6-ee5b358dc55b, initiatedEventID: 14, startedEventID: 15): activity error (type: gitlab.GitlabService_CreatePipeline, scheduledEventID: 49, startedEventID: 50, identity: 1@gitlab-worker-7dcd44ddbc-r5jkh@): POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/browser-sdk/pipeline: 400 {message: {base: [Reference not found]}} (type: ErrorResponse, retryable: true)

If you need support, contact us on Slack #devflow with those details!

@thomas-lebeau
Copy link
Copy Markdown
Collaborator Author

/trigger-ci

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Mar 25, 2026

View all feedbacks in Devflow UI.

2026-03-25 06:59:26 UTC ℹ️ Start processing command /trigger-ci


2026-03-25 06:59:42 UTC ℹ️ Branch synced on Gitlab

Branch thomas.lebeau/v7-remove-strategy-from-plugins was out-of-sync on Gitlab - it has been resynced


2026-03-25 06:59:44 UTC ℹ️ Gitlab pipeline started

Started pipeline #104267344

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Mar 25, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum N/A 172.33 KiB N/A N/A N/A
Rum Profiler N/A 6.18 KiB N/A N/A N/A
Rum Recorder N/A 27.48 KiB N/A N/A N/A
Logs N/A 56.53 KiB N/A N/A N/A
Rum Slim N/A 129.56 KiB N/A N/A N/A
Worker N/A 23.63 KiB N/A N/A N/A
🚀 CPU Performance

Pending...

🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
addglobalcontext N/A 34.67 KiB N/A
addaction N/A 58.47 KiB N/A
addtiming N/A 33.86 KiB N/A
adderror N/A 61.98 KiB N/A
startstopsessionreplayrecording N/A 33.16 KiB N/A
startview N/A 464.81 KiB N/A
logmessage N/A 51.06 KiB N/A

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Mar 25, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.31%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2eed4a6 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@thomas-lebeau thomas-lebeau marked this pull request as ready for review March 25, 2026 09:34
@thomas-lebeau thomas-lebeau merged commit 73ac57a into v7 Mar 25, 2026
19 of 20 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/v7-remove-strategy-from-plugins branch March 25, 2026 13:53
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 25, 2026
@ncreated ncreated restored the thomas.lebeau/v7-remove-strategy-from-plugins branch April 9, 2026 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants