💥 Remove deprecated strategy from plugin API#4382
Conversation
|
/trigger-ci |
|
View all feedbacks in Devflow UI.
Branch If you need support, contact us on Slack #devflow!
POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/browser-sdk/pipeline: 400 {message: {base: [Reference not found]}} DetailsIf you need support, contact us on Slack #devflow with those details! |
|
/trigger-ci |
|
View all feedbacks in Devflow UI.
Branch
Started pipeline #104267344 |
Bundles Sizes Evolution
🚀 CPU PerformancePending... 🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 2eed4a6 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Motivation
Simplification and code removal. The
strategyproperty onOnRumStartOptionswas deprecated in favor ofaddEvent. Removing it for v7.Customers using
rum-reactor custom plugins that rely onstrategywill need to upgrade to useaddEventinstead. This API may be used by customers in the wild, but it is unsupported.Changes
strategyproperty fromOnRumStartOptionsinterfaceStrategytype import fromplugins.tsstrategyin thecallPluginsMethodcall inrumPublicApi.tsTest instructions
yarn typecheckshould passstrategyin the plugin APIChecklist