💥 Rename chunk files to include "datadog" prefix for cross-bundler naming#4391
💥 Rename chunk files to include "datadog" prefix for cross-bundler naming#4391thomas-lebeau merged 3 commits intov7from
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: ae34631 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
ea0a10c to
d4fd13b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b20a529b8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b20a529 to
971e47e
Compare
971e47e to
0169de5
Compare
There was a problem hiding this comment.
suggestion: could we stick with the naming convention and use datadogRecorder.ts?
Use camelCase for lazy-loaded source files (datadogRecorder, datadogProfiler) to follow project naming conventions. Remove webpackChunkName magic comments since webpack derives chunk names from filenames. Unify chunk filename separator to hyphen in both dev and prod builds.
d6e6858 to
ae34631
Compare
|
|
Motivation
Chunk files produced by the SDK (recorder, profiler) use generic names like
recorder-<hash>andprofiler-<hash>. These can collide with chunks from other libraries or the application itself. Prefixing them withdatadog-makes them easily identifiable and avoids naming conflicts across bundlers.Changes
startRecording.tstodatadog-recorder.tsandprofiler.tstodatadog-profiler.tsrecorder/profilertodatadogRecorder/datadogProfilerTest instructions
yarn build && yarn build:appsand verify:packages/rum/bundle/chunks/are nameddatadogRecorder_<hash>-datadog-rum.jsanddatadogProfiler_<hash>-datadog-rum.jsdeveloper-extension/dist/chrome-mv3/chunksare nameddatadogRecorder_<hash>.jsanddatadogProfiler_<hash>.jsyarn test:unit --spec scripts/deploy/deploy.spec.tsto verify deploy tests passChecklist