🐛 Handle null deadline in taskQueue requestIdleCallback#4497
Merged
thomas-lebeau merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
- Some polyfills (e.g. `setTimeout(cb, 0)` in certain WKWebViews) invoke the idle callback with no argument, causing a crash when reading `deadline.didTimeout`. Fall back to the timeout execution budget when `deadline` is null.
mormubis
approved these changes
Apr 17, 2026
gogusarov
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some page-injected
requestIdleCallbackpolyfills (e.g.setTimeout(cb, 0)in some WKWebViews) invoke the callback without anIdleDeadlineargument. The current implementation assumesdeadlineis always defined and throws when accessingdeadline.didTimeout, breaking the task queue.Observed in SDK self-telemetry (US3, last 7d): ~89k
TypeErrors across 6 customer orgs, 100% WebKit (iOS Mobile Safari, desktop Safari, Chrome Mobile iOS, and in-app WKWebViews), ~99.8% on SDK v6.32.0.Sample stack trace:
Mapped to source: `taskQueue.ts` `run()` → `monitor.ts` `callMonitored` → `monitor.ts` wrapper.
Changes
Test instructions
Checklist