📝 Add README for rum-nuxt package#4506
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 2fe59e7 | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8a5c9f0ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: 'datadog-rum', | ||
| enforce: 'pre', | ||
| setup() { | ||
| datadogRum.init({ |
There was a problem hiding this comment.
I've just found out that defineNuxtPlugin, useRouter, and useNuxtApp are auto-imported in Nuxt, so the from 'nuxt/app' line isn't needed. https://nuxt.com/docs/guide/concepts/auto-imports#explicit-imports. What do you think? Should we adapt the example to Nuxt auto-import?
There was a problem hiding this comment.
I think both ways are fine. IMO I would prefer to leave it as the IDE considers it a linter error, even thought the application will build just fine. I think it does not hurt and prevents an import from the wrong component in case a developer wants to get rid of the linting issue locally.
Motivation
Now that Routing and Erorr handling has been merged in Nuxt, we can add its full documentation.
Changes
Adds
readme.mdfileTest instructions
Checklist