Merged
Conversation
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: c4c65b3 | Docs | Datadog PR Page | Give us feedback! |
|
All contributors have signed the CLA ✍️ ✅ |
mormubis
requested changes
Apr 27, 2026
Contributor
mormubis
left a comment
There was a problem hiding this comment.
Can you make a regression test?
d635188 to
ea56696
Compare
ea56696 to
9685831
Compare
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
BenoitZugmeyer
approved these changes
Apr 27, 2026
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
mormubis
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently used helper does not take into account the parsing of cookies which have empty values (eg
"foo=; hello=world") which leads to several problems:cookieis a default session strategy and we check if this strategy is available in areCookiesAuthorized by tryint to set a test cookie value & then read from this cookie; this check will fail if empty cookie goes before the test cookie)Changes
Fixed common utility function, updated corresponding unit test
Test instructions
https://regex101.com/r/3K03iT/1 - buggy behavior
https://regex101.com/r/3K03iT/2 - behavior after fix
Checklist