Skip to content

👷 Renovate: pin angular-app to its current Angular version#4565

Merged
thomas-lebeau merged 2 commits intomainfrom
thomas.lebeau/renovate-pin-angular-test-app
May 6, 2026
Merged

👷 Renovate: pin angular-app to its current Angular version#4565
thomas-lebeau merged 2 commits intomainfrom
thomas.lebeau/renovate-pin-angular-test-app

Conversation

@thomas-lebeau
Copy link
Copy Markdown
Collaborator

@thomas-lebeau thomas-lebeau commented May 6, 2026

Motivation

The test/apps/angular-app test app is intentionally pinned to a specific Angular version to exercise SDK behavior on that version. Renovate has been opening upgrade PRs for @angular/* packages in this app (e.g. #4482), which is not desired here.

This mirrors the existing pattern already used for react-router-v6-app / react-router-dom.

Changes

  • Disable Renovate updates for @angular/* packages scoped to test/apps/angular-app/**.

Test instructions

  • Inspect renovate.json and confirm the new packageRules entry matches the existing react-router-v6-app rule structure.
  • Future Renovate runs should no longer open PRs upgrading @angular/* in test/apps/angular-app.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

The angular-app test fixture is intentionally pinned to v15 (the floor
of @datadog/browser-rum-angular's supported peer range). Renovate
upgrading individual @angular/* packages mixes majors and breaks the
build.
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 6, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 179.65 KiB 179.65 KiB 0 B 0.00%
Rum Profiler 6.17 KiB 6.17 KiB 0 B 0.00%
Rum Recorder 27.03 KiB 27.03 KiB 0 B 0.00%
Logs 56.78 KiB 56.78 KiB 0 B 0.00%
Rum Slim 135.50 KiB 135.50 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance

Pending...

🧠 Memory Performance

Pending...

🔗 RealWorld

@thomas-lebeau thomas-lebeau marked this pull request as ready for review May 6, 2026 11:26
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner May 6, 2026 11:26
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented May 6, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.00% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ce1692d | Docs | Datadog PR Page | Give us feedback!

Angular v15 (which the fixture is pinned to) doesn't support modern
TypeScript majors. Group the typescript rule with @angular/* so both
allow patch/minor but block majors.
@thomas-lebeau thomas-lebeau merged commit 9b071fb into main May 6, 2026
22 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/renovate-pin-angular-test-app branch May 6, 2026 13:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants