Skip to content

🎨 [PANA-7353] Clean up naming in recording code#4628

Merged
sethfowler-datadog merged 2 commits into
mainfrom
seth.fowler/PANA-7353-clean-up-naming-in-recording-code
May 28, 2026
Merged

🎨 [PANA-7353] Clean up naming in recording code#4628
sethfowler-datadog merged 2 commits into
mainfrom
seth.fowler/PANA-7353-clean-up-naming-in-recording-code

Conversation

@sethfowler-datadog
Copy link
Copy Markdown
Contributor

Motivation

I'm about to start pushing a major new round of session replay improvements. Before that process starts, I'd like to take a moment to perform some cleanup. In SDK v6, the SDK included two serialization algorithms: the original one (v1) and the then-experimental replacement (change). In SDK v7, we've totally replaced the v1 algorithm with the change algorithm, but the split that previously existing remains visible in the naming of many functions and types which specify that they generate "change" output or work with the "change" codepath. Now that there's only one codepath, including "change" in all these names is unnecessary. Let's clean it up to make things a little less verbose.

Changes

This PR removes the term "change" everywhere in the recording code where it occurs unnecessarily. The term still appears, but only in places where it involves serialization logic for the Change record type itself; it's no longer spread throughout the code base.

This is a pure refactoring change; no functionality has been altered.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@sethfowler-datadog sethfowler-datadog requested review from a team as code owners May 14, 2026 17:06
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 14, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 173.61 KiB 173.61 KiB 0 B 0.00%
Rum Profiler 8.07 KiB 8.07 KiB 0 B 0.00%
Rum Recorder 21.23 KiB 21.23 KiB 0 B 0.00%
Logs 56.96 KiB 56.96 KiB 0 B 0.00%
Rum Slim 131.28 KiB 131.28 KiB 0 B 0.00%
Worker 22.99 KiB 22.99 KiB 0 B 0.00%

🔗 RealWorld

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented May 14, 2026

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.85% (+0.29%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0aeadb7 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown

@gonzalezreal gonzalezreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of nits

Comment thread packages/rum/src/domain/record/serialization/serializationTransaction.ts Outdated
Comment thread packages/rum/src/domain/record/test/serializeHtml.specHelper.ts Outdated
@sethfowler-datadog sethfowler-datadog force-pushed the seth.fowler/PANA-7353-clean-up-naming-in-recording-code branch from b51d153 to 0aeadb7 Compare May 27, 2026 14:20
@sethfowler-datadog sethfowler-datadog merged commit 1117c70 into main May 28, 2026
29 of 30 checks passed
@sethfowler-datadog sethfowler-datadog deleted the seth.fowler/PANA-7353-clean-up-naming-in-recording-code branch May 28, 2026 11:04
@github-actions github-actions Bot locked and limited conversation to collaborators May 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants