✅ Simplify debugger probe test fixtures#4736
Open
watson wants to merge 1 commit into
Open
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c4895cd | Docs | Datadog PR Page | Give us feedback! |
Add a shared browser-debugger probe fixture and use it across debugger domain specs. Keep tests focused on the fields they intentionally vary, while matching web-ui-style probe defaults for file path, capture depth, sampling, and evaluation time. Make Probe.sampling optional to reflect the delivery/schema contract and the runtime fallback path.
fa1fe97 to
c4895cd
Compare
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Debugger domain specs were repeating full probe objects in many places, making tests noisy and harder to review. This also made it easy for test fixtures to drift from the probe shapes delivered by the UI/API.
Changes
createProbe()spec helper for browser-debugger tests.Probe.samplingoptional to match the delivery schema/backend contract and existing runtime fallback handling.Test instructions
yarn test:unit --spec "packages/browser-debugger/src/domain/{api,probes,deliveryApi}.spec.ts"Checklist