Skip to content

✅ Make tanstack router use basePluginRouterTests#4746

Merged
BeltranBulbarellaDD merged 6 commits into
mainfrom
beltran.bulbarella/make-tanstack-use-baseplugintests
Jun 8, 2026
Merged

✅ Make tanstack router use basePluginRouterTests#4746
BeltranBulbarellaDD merged 6 commits into
mainfrom
beltran.bulbarella/make-tanstack-use-baseplugintests

Conversation

@BeltranBulbarellaDD
Copy link
Copy Markdown
Contributor

Motivation

Align tanstack router integration to use basePluginRouterTests

Changes

Move tanstackRouterPlugin.scenario to the plugin folder.
Replace tests with basePluginRouterTests, and keep unique tanstack tests.

Test instructions

CI should pass.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Jun 8, 2026

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.77% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6af9485 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Jun 8, 2026

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 171.86 KiB 171.86 KiB 0 B 0.00%
Rum Profiler 7.88 KiB 7.88 KiB 0 B 0.00%
Rum Recorder 21.21 KiB 21.21 KiB 0 B 0.00%
Logs 54.31 KiB 54.31 KiB 0 B 0.00%
Rum Slim 129.69 KiB 129.69 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@BeltranBulbarellaDD BeltranBulbarellaDD marked this pull request as ready for review June 8, 2026 09:54
@BeltranBulbarellaDD BeltranBulbarellaDD requested a review from a team as a code owner June 8, 2026 09:54
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6c72ef84d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test/apps/tanstack-router-app/app.tsx
Comment thread test/apps/tanstack-router-app/app.tsx Outdated
@BeltranBulbarellaDD BeltranBulbarellaDD merged commit 3848372 into main Jun 8, 2026
30 checks passed
@BeltranBulbarellaDD BeltranBulbarellaDD deleted the beltran.bulbarella/make-tanstack-use-baseplugintests branch June 8, 2026 14:28
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants