Skip to content

👷 fix performance benchmark CI and rename e2e setup script#4781

Merged
thomas-lebeau merged 1 commit into
mainfrom
thomas.lebeau/fix-performance-benchmark
Jun 15, 2026
Merged

👷 fix performance benchmark CI and rename e2e setup script#4781
thomas-lebeau merged 1 commit into
mainfrom
thomas.lebeau/fix-performance-benchmark

Conversation

@thomas-lebeau

@thomas-lebeau thomas-lebeau commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The performance benchmark CI job was failing because yarn test:performance what trying to install playwright browsers which is unnecessary as they are prebuild in the CI image.

Changes

  • Add yarn build and yarn build:apps steps to the performance-benchmark CI job so apps are built before running performance tests
  • Remove the build steps from the test:performance npm script (they now live in CI, keeping the local script lean and avoiding a double-build)
  • Rename test:e2e:inittest:e2e:setup for clarity; update all references in AGENTS.md, docs/TESTING.md, test/e2e/AGENTS.md, and test/e2e/playwright.config.ts

Test instructions

  • Verify CI performance benchmark job passes after this change
  • Locally, confirm yarn test:e2e:setup works as expected (same behavior as the old test:e2e:init)

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

- Add `yarn build` and `yarn build:apps` steps to the performance-benchmark
  CI job so apps are built before running performance tests
- Remove the build steps from the `test:performance` npm script (they now
  live in CI, keeping the local script lean)
- Rename `test:e2e:init` → `test:e2e:setup` for clarity; update all
  references in AGENTS.md, docs/TESTING.md, test/e2e/AGENTS.md and
  test/e2e/playwright.config.ts
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.04 KiB 172.04 KiB 0 B 0.00%
Rum Profiler 7.88 KiB 7.88 KiB 0 B 0.00%
Rum Recorder 21.09 KiB 21.09 KiB 0 B 0.00%
Logs 54.64 KiB 54.64 KiB 0 B 0.00%
Rum Slim 129.72 KiB 129.72 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 15, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.81% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b3bb065 | Docs | Datadog PR Page | Give us feedback!

@thomas-lebeau thomas-lebeau marked this pull request as ready for review June 15, 2026 08:47
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner June 15, 2026 08:47
@thomas-lebeau thomas-lebeau merged commit 50c12a5 into main Jun 15, 2026
32 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/fix-performance-benchmark branch June 15, 2026 12:22
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants