👷 fix performance benchmark CI and rename e2e setup script#4781
Merged
Conversation
- Add `yarn build` and `yarn build:apps` steps to the performance-benchmark CI job so apps are built before running performance tests - Remove the build steps from the `test:performance` npm script (they now live in CI, keeping the local script lean) - Rename `test:e2e:init` → `test:e2e:setup` for clarity; update all references in AGENTS.md, docs/TESTING.md, test/e2e/AGENTS.md and test/e2e/playwright.config.ts
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: b3bb065 | Docs | Datadog PR Page | Give us feedback! |
rgaignault
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The performance benchmark CI job was failing because
yarn test:performancewhat trying to install playwright browsers which is unnecessary as they are prebuild in the CI image.Changes
yarn buildandyarn build:appssteps to theperformance-benchmarkCI job so apps are built before running performance teststest:performancenpm script (they now live in CI, keeping the local script lean and avoiding a double-build)test:e2e:init→test:e2e:setupfor clarity; update all references inAGENTS.md,docs/TESTING.md,test/e2e/AGENTS.md, andtest/e2e/playwright.config.tsTest instructions
yarn test:e2e:setupworks as expected (same behavior as the oldtest:e2e:init)Checklist