fix: move webpack/rspack helper file out of outDir#305
Merged
yoannmoinet merged 2 commits intomasterfrom Apr 6, 2026
Merged
Conversation
When output.clean is enabled, webpack/rspack deletes the helper file from outDir during emit. On subsequent rebuilds (watch/dev mode), module resolution fails because the file is gone. Move the helper file to node_modules/.cache/datadog-build-plugins/ inside the project root — still resolvable by webpack/rspack, but outside the output directory so output.clean can't delete it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
elbywan
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes #304.
When
output.clean: trueis set in webpack/rspack, theCleanPlugindeletes the injection helper file (__datadog-helper-file.js) from the output directory during emit. On subsequent rebuilds (watch/dev mode), module resolution fails because the file no longer exists —apply()only runs once at compiler creation, so the file is never recreated.How?
Move the helper file from
context.bundler.outDirtonode_modules/.cache/datadog-build-plugins/inside the project root. This location is:output.cleancan't delete itnode_modules/node_modules/.cache/is the standard cache location for build toolsAlso adds a
cleanoption to the test infrastructure'sBundlerConfig, wired tooutput.clean(webpack/rspack) andbuild.emptyOutDir(Vite).The regression test creates a compiler once and runs it twice without closing — simulating watch/dev mode. Without the fix, the second build fails with a resolution error.