[APPS] Move inlineDynamicImports to shared backend build config#317
Draft
sdkennedy2 wants to merge 1 commit intomasterfrom
Draft
[APPS] Move inlineDynamicImports to shared backend build config#317sdkennedy2 wants to merge 1 commit intomasterfrom
sdkennedy2 wants to merge 1 commit intomasterfrom
Conversation
This was referenced Apr 7, 2026
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 3877b11 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
6898cb6 to
3877b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Both the production build (
buildBackendFunctions) and dev server build (bundleFunction) were independently settinginlineDynamicImports: truein their rollup output config. This duplication meant the shared base config didn't fully capture the contract that all backend function builds produce self-contained JS files.Changes
Moved
inlineDynamicImports: trueintogetBaseBackendBuildConfigso the shared config is the single source of truth for backend build behavior. Removed the redundant per-caller overrides and cleaned up stale comments that referenced the now-centralized setting.Also inlined the
virtualEntriesvariable in the production build loop — since we build one function at a time, there's no need for an intermediate variable holding a single-entry map.QA Instructions
This is a pure refactor with no behavior change. The same
inlineDynamicImports: truesetting is applied in the same place — just from the shared config instead of each caller.Blast Radius
Documentation