fix(live-debugger): exclude params from locals in instrumented code#335
Draft
watson wants to merge 1 commit intowatson/DEBUG-5465/inject-version-at-runtimefrom
Draft
Conversation
The locals helper passed to $dd_return included function parameters alongside actual local variables, causing the snapshot to duplicate argument values in both the arguments and locals sections. Change exitVars to only collect local variable declarations (not params), and omit the args/locals helpers entirely when they would be empty to reduce instrumented bundle size.
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What and why?
The live debugger build plugin was duplicating function parameters in the snapshot's locals section. When an instrumented function was captured at its return point, the
localsobject sent to the browser SDK contained both the function's local variable declarations and its parameters — even though parameters were already captured separately in theargumentsobject. This caused redundant data in debugger snapshots.How?
Transform change (
scopeTracker/index.ts):exitVars(the locals helper) fromgetVariableNames(node, true, true)togetVariableNames(node, false, true), so it only collects local variable declarations — not function parameters.$dd_returnare omitted entirely instead of passing an empty object, reducing instrumented bundle size.$dd_entry/$dd_return/$dd_throwis dropped. If locals are present but params are not,undefinedis passed as a positional placeholder for args in$dd_return.Generated output for each case:
$dd_entry/$dd_throw$dd_return(probes, this)(probes, rv, this)(probes, this)(probes, rv, this, undefined, $dd_l())(probes, this, $dd_e())(probes, rv, this, $dd_e())(probes, this, $dd_e())(probes, rv, this, $dd_e(), $dd_l())