[CLOSED][APPS] Folded into #349: Refactor connection ID extraction modules#352
Closed
sdkennedy2 wants to merge 1 commit intosdkennedy2/poc-eslint-scope-walkerfrom
Closed
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 8, 2026
sdkennedy2
changed the title
sdkennedy2
changed the title
sdkennedy2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This prepares the connection ID extraction stack for same-module and module-graph resolution work by separating the current inline extractor into smaller responsibility-focused modules. The goal of this PR is reviewability: move existing behavior into clearer boundaries before adding new resolver semantics in the next PR.
Changes
This is intended to be behavior-neutral relative to #349.
The existing extractor code is split under
packages/plugins/apps/src/backend/ast-parsing/:action-catalog-imports.tsowns action-catalog import detection and type-only import filtering.action-catalog-call-sites.tsownseslint-scopeanalysis, shadow-safe action-catalog call classification, and unsupported action alias detection.connection-id-values.tsownsconnectionIdproperty lookup and inline string literal extraction.extract-connection-ids.tsremains the public orchestration entrypoint that validates the AST, finds action-catalog calls, extracts IDs, and returns the sorted/deduped file-level union.This PR should preserve #349 behavior: inline string literal
connectionIdvalues are supported, and non-inline values still fail closed for known action-catalog calls.QA Instructions
The existing extractor tests continue to cover the behavior moved into the new modules. CI/CD will run lint, typecheck, and the test suite for this stack.
Blast Radius
This affects Apps backend function connection ID extraction internals only. It should not change the generated manifest behavior or runtime backend execution.
Documentation