[APPS][Connections Part 9] Refactor action catalog module scope boundary#373
Open
sdkennedy2 wants to merge 1 commit into
Open
[APPS][Connections Part 9] Refactor action catalog module scope boundary#373sdkennedy2 wants to merge 1 commit into
sdkennedy2 wants to merge 1 commit into
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
This is the first slice split out of the previous all-in-one module graph PR. Before enriching module graph records, the shared eslint-scope analysis needs to live outside the action-catalog-specific call-site logic so module graph parsing can reuse identifier resolution without depending on connection ID or action catalog concepts.
Changes
This introduces a domain-neutral
ModuleScopeAnalysishelper for parsed backend ES modules. It owns the eslint-scope manager, reference lookup by identifier node, and module-scope variable lookup.Action catalog parsing now layers
ActionCatalogScopeAnalysison top ofModuleScopeAnalysis:Connection ID value extraction now receives the generic module scope analysis directly. That keeps identifier-to-definition resolution shared while leaving action-catalog call classification and connection ID value resolution as separate domain concerns.
QA Instructions
No manual QA; this is an internal AST parsing refactor covered by CI.
Blast Radius
This only affects backend apps AST parsing used to discover action-catalog connection IDs. It should be behavior-preserving: the same call-site and same-module connection ID extraction tests continue to cover the changed boundary.
Documentation