[TON-513] Fix workflow instrumentation permissions#314
Conversation
gpalmz
left a comment
There was a problem hiding this comment.
LGTM. Left one note about parity with main_extended.yaml.
| ExternalId: !Ref ExternalId | ||
| IAMRoleName: !Ref IAMRoleName | ||
| ResourceCollectionPermissions: !If [ResourceCollectionPermissions, true, false] | ||
| InstrumentationResourceTypes: !Join [",", !Ref InstrumentationResourceTypes] |
There was a problem hiding this comment.
main_extended.yaml looks like it has the same gap. Its DatadogIntegrationRoleStack invocation doesn't forward InstrumentationResourceTypes or DatadogSite to the nested stack either, so users launching that template manually (instead of via the Datadog UI) would hit the same missing-perms behavior this PR fixes for the workflow path. Worth folding in here, or filing a follow-up?
There was a problem hiding this comment.
Good catch, I'll fold the fix in with this PR
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
What does this PR do?
Forwards InstrumentationResourceTypes and DatadogSite from the Datadog UI workflow templates into the nested integration role stack. This lets workflow-launched stacks attach the Agent instrumentation IAM permissions selected during onboarding, matching the existing main_v2.yaml behavior.
Also bumps aws_quickstart to v4.11.1 and documents the change.
Testing
Note: cfn-lint still reports pre-existing warnings for CloudSecurityPostureManagementPermissions, unused DisableMetricCollection, and redundant ForwarderStack dependencies.