Skip to content

Conversation

@avidal
Copy link
Collaborator

@avidal avidal commented Jul 9, 2025

This patch introduces the commit subcommand, suitable for simple use cases where a single commit is all that's necessary, and the set of files that were changed is known in advance.

See the updates to the README and the help output for more.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jul 9, 2025

✅ Code Quality    ✅ Code Vulnerabilities    ✅ Libraries

ℹ️ Info

🎉 All green!

🛠️ No new code quality issues
🛡️ No new code vulnerabilities
📚 No new vulnerable libraries detected

This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 39d23b0 | Was this helpful? Give us feedback!

@avidal
Copy link
Collaborator Author

avidal commented Jul 9, 2025

cc @mar-kolya

This new API may be better suited for profiling-backend since it's a known set of files that are changing. Your script could then be even further simplified because it won't have to do anything with git (including the git config changes).

We'll circle back on that once this gets cleaned up and released, but I don't think we should defer https://github.com/DataDog/profiling-backend/pull/6970 for this, as that PR is working as-is.

Copy link

@drewcsillagdd drewcsillagdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the one nit comment

This patch introduces the commit subcommand, suitable for simple use
cases where a single commit is all that's necessary, and the set of
files that were changed is known in advance.

See the updates to the README and the help output for more.
@avidal
Copy link
Collaborator Author

avidal commented Jul 10, 2025

Alright, this has been factored on top of #16 so it's largely only the implementation of the commit subcommand, which itself is just a bit of flag verification and file reading.

@avidal avidal merged commit 1d22641 into main Jul 10, 2025
7 checks passed
@avidal avidal deleted the commit-command branch July 10, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants