[SINT-5243] Move macOS signing steps to a protected environment#280
Merged
chouetz merged 1 commit intoMay 26, 2026
Merged
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 3498f36 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrates macOS package signing to a protected environment running only on
mainand tags, leaving the ability for non-mainbuilds to create unsigned and non-notarized packages.Mirrors what was done in
ddqain DataDog/ddqa#141 and DataDog/ddqa#153. The main difference is the need to have two sets of certificates: one to sign binaries, and one to sign the pkg file.