Skip to content

fix(install): Force a split of arguments#42

Merged
ofek merged 3 commits intoinstallfrom
nschweitzer/fix_string_split
Mar 7, 2025
Merged

fix(install): Force a split of arguments#42
ofek merged 3 commits intoinstallfrom
nschweitzer/fix_string_split

Conversation

@chouetz
Copy link
Member

@chouetz chouetz commented Mar 7, 2025

When we pass several space-separated arguments they are not split (https://github.com/DataDog/datadog-agent/actions/runs/13721504767/job/38377820759). We have the error invalid value 'legacy-tasks legacy-github legacy-release' for '--only-group <ONLY_GROUP>' The iteration on string token does not work on all shell versions. Addition of echo in the middle make it more portable

chouetz added 3 commits March 7, 2025 17:50
When we pass several space-separated arguments they are not split (https://github.com/DataDog/datadog-agent/actions/runs/13721504767/job/38377820759).
We have the error invalid value 'legacy-tasks legacy-github legacy-release' for '--only-group <ONLY_GROUP>'
The iteration on string token does not work on all shell versions. Addition of `echo` in the middle make it more portable
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ofek ofek merged commit 1133022 into install Mar 7, 2025
4 checks passed
@ofek ofek deleted the nschweitzer/fix_string_split branch March 7, 2025 17:32
chouetz added a commit to DataDog/datadog-agent that referenced this pull request Mar 10, 2025
In the current version of `dda` there is a loop in shell not working for any bash, and causing error in `bump_integrations_core` job https://github.com/DataDog/datadog-agent/actions/runs/13721504767/job/38377820759. This issue has been fixed in the last version of dda DataDog/datadog-agent-dev#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments