Skip to content

[OnCall] replacing connection name with unique name #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[OnCall] replacing connection name with unique name #2304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-04 12:49:25.614589",
"spec_repo_commit": "73e22797"
"regenerated": "2025-04-04 16:55:51.112810",
"spec_repo_commit": "da94868e"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-04 12:49:25.630699",
"spec_repo_commit": "73e22797"
"regenerated": "2025-04-04 16:55:51.129680",
"spec_repo_commit": "da94868e"
}
}
}
2 changes: 1 addition & 1 deletion ...s/v2/action_connection/Create-a-new-Action-Connection-returns-Bad-Request-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:35.383Z
2025-03-26T20:24:59.622Z
2 changes: 1 addition & 1 deletion ...ures/v2/action_connection/Create-a-new-Action-Connection-returns-Bad-Request-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...te-a-new-Action-Connection-returns-Successfully-created-Action-Connection-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:35.598Z
2025-03-26T20:24:59.727Z
12 changes: 6 additions & 6 deletions ...reate-a-new-Action-Connection-returns-Successfully-created-Action-Connection-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .../action_connection/Delete-an-existing-Action-Connection-returns-Not-Found-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:36.467Z
2025-03-26T20:25:00.311Z
2 changes: 1 addition & 1 deletion .../v2/action_connection/Delete-an-existing-Action-Connection-returns-Not-Found-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ...-existing-Action-Connection-returns-The-resource-was-deleted-successfully-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2025-03-26T20:25:00.458Z
61 changes: 61 additions & 0 deletions ...-an-existing-Action-Connection-returns-The-resource-was-deleted-successfully-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...2/action_connection/Get-an-existing-Action-Connection-returns-Bad-Request-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:37.403Z
2025-03-26T20:25:01.150Z
2 changes: 1 addition & 1 deletion ...s/v2/action_connection/Get-an-existing-Action-Connection-returns-Bad-Request-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .../v2/action_connection/Get-an-existing-Action-Connection-returns-Not-Found-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:37.563Z
2025-03-26T20:25:01.247Z
2 changes: 1 addition & 1 deletion ...res/v2/action_connection/Get-an-existing-Action-Connection-returns-Not-Found-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...-an-existing-Action-Connection-returns-Successfully-get-Action-Connection-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:37.743Z
2025-03-26T20:25:01.398Z
4 changes: 2 additions & 2 deletions ...Get-an-existing-Action-Connection-returns-Successfully-get-Action-Connection-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...ction_connection/Update-an-existing-Action-Connection-returns-Bad-Request-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:38.001Z
2025-03-26T20:25:01.521Z
2 changes: 1 addition & 1 deletion ...2/action_connection/Update-an-existing-Action-Connection-returns-Bad-Request-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .../action_connection/Update-an-existing-Action-Connection-returns-Not-Found-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:38.092Z
2025-03-26T20:25:01.625Z
2 changes: 1 addition & 1 deletion .../v2/action_connection/Update-an-existing-Action-Connection-returns-Not-Found-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...existing-Action-Connection-returns-Successfully-updated-Action-Connection-response.frozen
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2025-01-06T22:02:38.186Z
2025-03-26T20:25:01.719Z
4 changes: 2 additions & 2 deletions ...an-existing-Action-Connection-returns-Successfully-updated-Action-Connection-response.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/v2/action-connection/CreateActionConnection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
data: DatadogAPIClient::V2::ActionConnectionData.new({
type: DatadogAPIClient::V2::ActionConnectionDataType::ACTION_CONNECTION,
attributes: DatadogAPIClient::V2::ActionConnectionAttributes.new({
name: "Cassette Connection DELETE_ME",
name: "Cassette Connection exampleactionconnection",
integration: DatadogAPIClient::V2::AWSIntegration.new({
type: DatadogAPIClient::V2::AWSIntegrationType::AWS,
credentials: DatadogAPIClient::V2::AWSAssumeRole.new({
Expand Down
5 changes: 4 additions & 1 deletion examples/v2/action-connection/DeleteActionConnection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,7 @@

require "datadog_api_client"
api_instance = DatadogAPIClient::V2::ActionConnectionAPI.new
api_instance.delete_action_connection("connection_id")

# there is a valid "action_connection" in the system
ACTION_CONNECTION_DATA_ID = ENV["ACTION_CONNECTION_DATA_ID"]
api_instance.delete_action_connection(ACTION_CONNECTION_DATA_ID)
8 changes: 0 additions & 8 deletions examples/v2/action-connection/DeleteActionConnection_2142905164.rb
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions features/v2/action_connection.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Feature: Action Connection
@team:DataDog/workflow-automation-dev
Scenario: Create a new Action Connection returns "Successfully created Action Connection" response
Given new "CreateActionConnection" request
And body with value {"data":{"type":"action_connection","attributes":{"name":"Cassette Connection DELETE_ME","integration":{"type":"AWS","credentials":{"type":"AWSAssumeRole","role":"MyRoleUpdated","account_id":"123456789123"}}}}}
And body with value {"data":{"type":"action_connection","attributes":{"name":"Cassette Connection {{ unique_lower_alnum }}","integration":{"type":"AWS","credentials":{"type":"AWSAssumeRole","role":"MyRoleUpdated","account_id":"123456789123"}}}}}
When the request is sent
Then the response status is 201 Successfully created Action Connection

Expand All @@ -36,20 +36,13 @@ Feature: Action Connection
Then the response status is 404 Not Found

@team:DataDog/workflow-automation-dev
Scenario: Delete an existing Action Connection returns "Successfully deleted Action Connection" response
Scenario: Delete an existing Action Connection returns "The resource was deleted successfully." response
Given there is a valid "action_connection" in the system
And new "DeleteActionConnection" request
And request contains "connection_id" parameter from "action_connection.data.id"
When the request is sent
Then the response status is 204 The resource was deleted successfully.

@generated @skip @team:DataDog/workflow-automation-dev
Scenario: Delete an existing Action Connection returns "The resource was deleted successfully." response
Given new "DeleteActionConnection" request
And request contains "connection_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 204 The resource was deleted successfully.

@team:DataDog/workflow-automation-dev
Scenario: Get an existing Action Connection returns "Bad Request" response
Given new "GetActionConnection" request
Expand Down
2 changes: 1 addition & 1 deletion features/v2/given.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"parameters": [
{
"name": "body",
"value": "{\n \"data\": {\n \"type\": \"action_connection\",\n \"attributes\": {\n \"name\": \"Cassette Connection DELETE\",\n \"integration\": {\n \"type\": \"AWS\",\n \"credentials\": {\n \"type\": \"AWSAssumeRole\",\n \"role\": \"MyRole\",\n \"account_id\": \"123456789123\"\n }\n }\n }\n }\n}"
"value": "{\n \"data\": {\n \"type\": \"action_connection\",\n \"attributes\": {\n \"name\": \"Cassette Connection {{ unique_lower_alnum }}\",\n \"integration\": {\n \"type\": \"AWS\",\n \"credentials\": {\n \"type\": \"AWSAssumeRole\",\n \"role\": \"MyRole\",\n \"account_id\": \"123456789123\"\n }\n }\n }\n }\n}"
}
],
"step": "there is a valid \"action_connection\" in the system",
Expand Down
Loading