Allow cursor-based pagination to query extra page until collection is empty#1607
Merged
Conversation
… empty Cursor-based paginators now keep querying until the response collection is empty, instead of stopping early when a page returns fewer items than the requested limit. Page-offset and page-number paginations keep their existing behavior. Mirrors datadog-api-client-go#3769 and datadog-api-client-java#3790. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mirrors datadog-api-client-go#3769 and datadog-api-client-java#3790 for the Rust client.
Cursor-based paginators now keep querying until the response collection is empty (
count == 0), instead of stopping early when a page returns fewer items than the requested limit (count < page_size). Page-offset and page-number paginations keep their existing behavior. The generator template (api.j2) conditionally emits the appropriate stop condition based on whethercursorParamis present, and all 13 affected generated API files (24 cursor-based pagination functions) have been updated accordingly. Test cassettes already had the trailing{"data":[]}responses pre-staged.Additional Notes
Compiles cleanly with
cargo check.Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.