Fix GitHub workflows and tests#2
Conversation
|
❌ Critical Tests Failed One or more critical test suites failed. These packages are critical to KICS security scanning functionality. This PR cannot be merged until these tests pass. Please review the test failures and fix the issues. |
|
❌ Critical Tests Failed One or more critical test suites failed. These packages are critical to KICS security scanning functionality. This PR cannot be merged until these tests pass. Please review the test failures and fix the issues. |
c829135 to
1e7d214
Compare
|
❌ Critical Tests Failed One or more critical test suites failed. These packages are critical to KICS security scanning functionality. This PR cannot be merged until these tests pass. Please review the test failures and fix the issues. |
Also fix ChangeCurrentDir so it won't loop forever if the desired directory is not in the current path.
|
✅ dbt Impact Preview dbt Impact Preview (placeholder) This is a test comment from the dbt-cicd provider. This comment will be updated automatically if new data arrives.🔗 Commit SHA: 1cd49a8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
|
🎯 Code Coverage (details) 🔗 Commit SHA: 1cd49a8 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
…age-1 [CICD Coverage #2] HIGH Severity rules
…acy-rule-id-2 [ID Migration #2] Move ID for Ansible
Motivation
GitHub workflows were not executing, or if they executed, they were not completing.
Changes
vXXXtags, which is not safe and is not allowed by the repo settings, making the workflows fail. They've been switched to commit SHA pinning.kics(which was meant to be the repository's name). In this repository, no such directory exists. Changed those tests to look fordatadog-iac-scannerand fixed the function that changed directory so it will fail if it reaches the filesystem root without finding the directory.pkg/scanneras it's not that slow.Author Checklist
QA Instruction
We can tell it works because the GitHub checks below have passed.
Blast Radius
What services will this change impact. Is it only DataDog IaC Scanner, internal services, the documentation or anything else?
Additional Notes
If you need to share anything else along with your PR, please do it here.
I submit this contribution under the Apache-2.0 license.