Skip to content

Fix GitHub workflows and tests#2

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
jacobotb/noticket/pin-action-versions
Feb 19, 2026
Merged

Fix GitHub workflows and tests#2
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
jacobotb/noticket/pin-action-versions

Conversation

@jacobotb
Copy link
Copy Markdown
Collaborator

@jacobotb jacobotb commented Feb 18, 2026

Motivation

GitHub workflows were not executing, or if they executed, they were not completing.

Changes

  • Some actions were defined using vXXX tags, which is not safe and is not allowed by the repo settings, making the workflows fail. They've been switched to commit SHA pinning.
  • Some actions were not allowed because they were not owned by GitHub, DataDog, or a verified Marketplace action. They've been approved specifically.
  • Some tests timed out. This was caused by those tests trying to locate a parent subdirectory named kics (which was meant to be the repository's name). In this repository, no such directory exists. Changed those tests to look for datadog-iac-scanner and fixed the function that changed directory so it will fail if it reaches the filesystem root without finding the directory.
  • Added an API key and environment variables to upload the coverage report.
  • Changed the "critical tests" gate to remove KICS references and add pkg/scanner as it's not that slow.

Author Checklist

  • I have reviewed my own PR.
  • I have added or updated relevant unit tests where necessary. If no tests are added, I've explained why.
  • All new and existing tests pass.
  • I have tested my changes on staging (if applicable).
  • I have updated any relevant documentation (if applicable).

QA Instruction

We can tell it works because the GitHub checks below have passed.

Blast Radius

What services will this change impact. Is it only DataDog IaC Scanner, internal services, the documentation or anything else?

Additional Notes

If you need to share anything else along with your PR, please do it here.

I submit this contribution under the Apache-2.0 license.

@jacobotb jacobotb requested a review from a team as a code owner February 18, 2026 14:36
@github-actions
Copy link
Copy Markdown

Critical Tests Failed

One or more critical test suites failed. These packages are critical to KICS security scanning functionality.

This PR cannot be merged until these tests pass.

Please review the test failures and fix the issues.

View workflow run

@github-actions
Copy link
Copy Markdown

Critical Tests Failed

One or more critical test suites failed. These packages are critical to KICS security scanning functionality.

This PR cannot be merged until these tests pass.

Please review the test failures and fix the issues.

View workflow run

@jacobotb jacobotb force-pushed the jacobotb/noticket/pin-action-versions branch from c829135 to 1e7d214 Compare February 18, 2026 21:47
@github-actions
Copy link
Copy Markdown

Critical Tests Failed

One or more critical test suites failed. These packages are critical to KICS security scanning functionality.

This PR cannot be merged until these tests pass.

Please review the test failures and fix the issues.

View workflow run

@datadog-staging-us1-crawler-test
Copy link
Copy Markdown

✅ dbt Impact Preview

dbt Impact Preview (placeholder)

This is a test comment from the dbt-cicd provider.

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1cd49a8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@datadog-datadog-prod-us1
Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 41.67%
Overall Coverage: 42.47%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1cd49a8 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@jacobotb jacobotb changed the title Pin action versions Fix GitHub workflows Feb 19, 2026
@jacobotb jacobotb changed the title Fix GitHub workflows Fix GitHub workflows and tests Feb 19, 2026
@jacobotb
Copy link
Copy Markdown
Collaborator Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Feb 19, 2026

View all feedbacks in Devflow UI.

2026-02-19 17:00:08 UTC ℹ️ Start processing command /merge


2026-02-19 17:00:13 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 0s (p90).


2026-02-19 17:07:34 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 149d8d9 into main Feb 19, 2026
14 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the jacobotb/noticket/pin-action-versions branch February 19, 2026 17:07
ChouraquiBen added a commit that referenced this pull request Apr 13, 2026
…age-1

[CICD Coverage #2] HIGH Severity rules
ChouraquiBen added a commit that referenced this pull request May 12, 2026
…acy-rule-id-2

[ID Migration #2] Move ID for Ansible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants