[SVLS-8969] feat(scripts): add fed-us2 environment support to publish_govcloud_layers.sh#1192
Merged
[SVLS-8969] feat(scripts): add fed-us2 environment support to publish_govcloud_layers.sh#1192
Conversation
…yers.sh Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d_layers.sh Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…_govcloud_layers.sh" This reverts commit 1f6bf79.
lym953
requested review from
Copilot and
duncanista
and removed request for
Copilot
lym953
changed the title
duncanista
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds fed-us2 as a supported target for publish_govcloud_layers.sh, aligning its behavior with us1-fed (explicit VERSION, permissions enabled, no auto-bump).
Changes:
- Extend
ENVIRONMENThandling to acceptfed-us2. - Configure AWS Vault role and publishing flags for
fed-us2. - Update usage/help text and unsupported-environment error message.
Comment on lines
+60
to
+61
| elif [ $ENVIRONMENT = "fed-us2" ]; then | ||
| AWS_VAULT_ROLE=sso-govcloud-fed-us2-lambda-layer-operator |
There was a problem hiding this comment.
The elif [ $ENVIRONMENT = "fed-us2" ]; then condition leaves $ENVIRONMENT unquoted. For consistency with the earlier if [ "$ENVIRONMENT" = ... ] and to avoid word-splitting/globbing edge cases, quote it (or use [[ ... ]]).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
I don't think integration test failures are relevant. Ignoring them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fed-us2as a supportedENVIRONMENTvalue inpublish_govcloud_layers.shsso-govcloud-fed-us2-lambda-layer-operatorAWS Vault roleus1-fedbehavior: requires explicitVERSION, enables layer version permissions, disables auto-bumpTesting
Ran the script and published the layers to fed-us2.