Skip to content

chore(codeowners): add apm-serverless as co-owner of bottlecap/src/traces/#1195

Merged
lucaspimentel merged 2 commits intomainfrom
lpimentel/codeowners-apm-serverless
Apr 21, 2026
Merged

chore(codeowners): add apm-serverless as co-owner of bottlecap/src/traces/#1195
lucaspimentel merged 2 commits intomainfrom
lpimentel/codeowners-apm-serverless

Conversation

@lucaspimentel
Copy link
Copy Markdown
Member

@lucaspimentel lucaspimentel commented Apr 21, 2026

Overview

  • Add @DataDog/apm-serverless as co-owner of bottlecap/src/traces/ alongside @DataDog/serverless-aws in .github/CODEOWNERS.
  • Delete the root CODEOWNERS file; the one in .github/ takes precedence, so the root file was dead weight.

Testing

  • Verified via GitHub UI that the .github/CODEOWNERS rules resolve correctly for files under bottlecap/src/traces/.

"Two teams, one codepath — may your review notifications be ever balanced." — Claude 🤖

@lucaspimentel lucaspimentel changed the title add team apm-serverless as co-owners of tracing files [CODEOWNERS] Add apm-serverless as co-owner of bottlecap traces Apr 21, 2026
@lucaspimentel lucaspimentel marked this pull request as ready for review April 21, 2026 20:47
@lucaspimentel lucaspimentel requested a review from a team as a code owner April 21, 2026 20:47
@lucaspimentel lucaspimentel changed the title [CODEOWNERS] Add apm-serverless as co-owner of bottlecap traces chore(codeowners): add apm-serverless as co-owner of bottlecap traces Apr 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CODEOWNERS ownership to add @DataDog/apm-serverless as a co-owner for Bottlecap traces, and removes the redundant root-level CODEOWNERS file.

Changes:

  • Removed the root CODEOWNERS file (redundant when .github/CODEOWNERS exists).
  • Added a specific CODEOWNERS rule for bottlecap/src/traces/ assigning both @DataDog/serverless-aws and @DataDog/apm-serverless.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
CODEOWNERS Deleted the root CODEOWNERS file.
.github/CODEOWNERS Added explicit co-ownership for bottlecap/src/traces/.

@lucaspimentel lucaspimentel changed the title chore(codeowners): add apm-serverless as co-owner of bottlecap traces chore(codeowners): add apm-serverless as co-owner of bottlecap/src/traces/ Apr 21, 2026
Comment thread CODEOWNERS
@@ -1 +0,0 @@
* @DataDog/serverless No newline at end of file
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was being ignored because .github/CODEOWNERS takes precedence.

@lucaspimentel lucaspimentel merged commit 4134b07 into main Apr 21, 2026
51 of 53 checks passed
@lucaspimentel lucaspimentel deleted the lpimentel/codeowners-apm-serverless branch April 21, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants