Skip to content

Conversation

@alexgallotta
Copy link
Contributor

@alexgallotta alexgallotta commented Sep 8, 2023

example of the diff

--- all_layers_af-south-1.log	2023-09-08 11:53:10.813636954 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_ap-east-1.log	2023-09-08 11:53:28.145722728 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_ap-northeast-3.log	2023-09-08 11:53:18.501675700 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_ap-south-2.log	2023-09-08 11:52:55.693557416 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
+464622532012:layer:Datadog-Extension-ARM-OTEL:3",
+464622532012:layer:Datadog-Extension-OTEL:3",
-464622532012:layer:dd-trace-java:9",
+464622532012:layer:dd-trace-java:11",
--- all_layers_ap-southeast-3.log	2023-09-08 11:53:34.825754285 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_ap-southeast-4.log	2023-09-08 11:53:36.605762554 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
+464622532012:layer:Datadog-Extension-ARM-OTEL:3",
+464622532012:layer:Datadog-Extension-OTEL:3",
-464622532012:layer:dd-trace-java:5",
+464622532012:layer:dd-trace-java:11",
--- all_layers_eu-central-1.log	2023-09-08 11:53:05.069607263 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_eu-central-2.log	2023-09-08 11:53:06.257613456 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
+464622532012:layer:Datadog-Extension-ARM-OTEL:3",
+464622532012:layer:Datadog-Extension-OTEL:3",
--- all_layers_eu-north-1.log	2023-09-08 11:53:12.445645273 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_eu-south-1.log	2023-09-08 11:52:59.245576502 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_eu-south-2.log	2023-09-08 11:53:00.593583680 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
+464622532012:layer:Datadog-Extension-ARM-OTEL:3",
+464622532012:layer:Datadog-Extension-OTEL:3",
--- all_layers_me-central-1.log	2023-09-08 11:53:02.453593526 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_me-south-1.log	2023-09-08 11:53:22.353694693 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400
--- all_layers_us-east-2.log	2023-09-08 11:53:38.733772367 -0400
+++ all_layers_us-east-1.log	2023-09-08 11:53:37.657767416 -0400

Planning to add hash checksum verification, since version number is not reliable

@alexgallotta alexgallotta requested a review from a team as a code owner September 8, 2023 18:23
ap-southeast-3
ap-southeast-4
us-east-1
us-east-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an automated way to generate this, since we will be adding more in the future. It would be a pain to have to update this one file every time we add a new region.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this is done already in this function
https://github.com/DataDog/datadog-lambda-extension/pull/166/files#diff-260f0a0f31567ce6be2509b618b7298adfdb12ae2a72191a93f6b17d4cfb7827R1

I saved the file here since it doesn't happen very often

@alexgallotta alexgallotta merged commit ad34bcf into main Sep 20, 2023
@alexgallotta alexgallotta deleted the SVLS-3006-layer-regions branch September 20, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants