aj/add hello route #311
Merged
aj/add hello route #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanista
reviewed
Jul 9, 2024
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
Are there any cold start implications by starting another server?
Contributor
Author
|
I doubt it, but it doesn't matter. We have to support it until we fully deprecate it. I'd love if we could do that today, but an alpha user already ran into this so I don't think it's quite time to deprecate it on the server-side. |
duncanista
approved these changes
Jul 9, 2024
…ation metric from clients because we always set it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
helloroute was a path used to tell the tracers that the agent is ready to receive data. It goes back to the original PR for the extension.It was eventually removed but somehow lives on.
We've since removed it in all lambda layers, but a smoke test revealed that a user was still using it as late as layer v85.
We should remove this entirely at some point, but that would effectively be a breaking change for all versions of the clients/tracers.