chore: consolidate scripts#568
Merged
duncanista merged 12 commits intomainfrom Feb 26, 2025
Merged
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| FROM ubuntu:22.04 AS compresser | ||
| ARG SUFFIX | ||
|
|
||
| RUN apt-get update && apt-get install -y zip binutils |
There was a problem hiding this comment.
⚪ Code Quality Violation
package zip should have version pinned (...read more)
When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.
duncanista
commented
Feb 26, 2025
|
|
||
| if [ -z "$SUFFIX" ]; then | ||
| printf "No suffix provided, using ${ARCHITECTURE}\n" | ||
| SUFFIX=$ARCHITECTURE |
Contributor
Author
There was a problem hiding this comment.
Most of these changes are OK because they're only used locally!
astuyve
approved these changes
Feb 26, 2025
Contributor
astuyve
left a comment
astuyve
left a comment
There was a problem hiding this comment.
LGTM let's make sure to test this thoroughly in staging/self monitoring before releasing the next version
alexgallotta
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Consolidates Dockerfile images and scripts in one place.
Motivation
There is a bunch of scripts and images repeated across the repo, I wanted to clean it for a better dev experience.