fix: update pipeline and dev scripts#578
Merged
duncanista merged 12 commits intomainfrom Feb 28, 2025
Merged
Conversation
it doesnt need incoming suffix because layers only use architecture and alpine will never be available
we rely on alpine images :l
astuyve
approved these changes
Feb 28, 2025
Contributor
astuyve
left a comment
astuyve
left a comment
There was a problem hiding this comment.
LGTM, tested with ARCHITECTURE=amd64 REGION=sa-east-1 ./scripts/publish_bottlecap_sandbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes local bottlecap dev scripts
How?
Modifying
SUFFIXtoFILE_SUFFIXto make it more clear.Tests
and
Notes
I tried removing
suffixoverall in thedatasources/flavors.yamlbut it just complicates things more, I still think we shouldnt have it tho.