[Integration test] Add support for DD_TAGS and DD_EXTRA_TAGS #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maxday
commented
Jun 11, 2021
maxday
commented
- Add integration tests for DD_TAGS and DD_EXTRA_TAGS for both metrics and tags
- Trigger Github-Action on push on files related to integration tests to make review easier (and not to wait for the cron job to see whether or not tests are successful)
nhinsch
reviewed
Jun 11, 2021
| app.post('/v1/input', async (req, res) => { | ||
| if(JSON.stringify(req.body) !== '{}') { // to avoid printing empty logs due to the connectivity test | ||
| for(let i = 0; i < req.body.length; ++i) { | ||
| //sort tags to avoid flakky tests |
nhinsch
reviewed
Jun 11, 2021
| // reset tags once sorted | ||
| req.body[i].ddtags = sortedTags.join(",") | ||
| const logString = JSON.stringify(req.body[i]); | ||
| if(logString.indexOf("[sketch]") === -1 && logString.indexOf("[log]") === -1) { // avoid inception |
Contributor
There was a problem hiding this comment.
What do you mean by "avoid inception" here? I would make this comment a bit more specific.
nhinsch
approved these changes
Jun 11, 2021
Contributor
nhinsch
left a comment
nhinsch
left a comment
There was a problem hiding this comment.
Looks great! Hooray for integration tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.