[SVLS-8231] fixing log requestId for LMI #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
approved these changes
Dec 30, 2025
Comment on lines
+111
to
+116
| if is_oom_error(&message) { | ||
| debug!("LOGS | Got a runtime-specific OOM error. Incrementing OOM metric."); | ||
| if let Err(e) = self.event_bus.send(Event::OutOfMemory(event.time.timestamp())).await { | ||
| error!("LOGS | Failed to send OOM event to the main event bus: {e}"); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I think we can delete the if is_oom_error(&message) {} block in the TelemetryRecord::Extension case below. I think runtime-specific OOM errors can only come from the function.
Contributor
Author
There was a problem hiding this comment.
Are we able to validate that? I would have though that extensions can also have an OOM error.
Contributor
Author
There was a problem hiding this comment.
Will leave for now to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/SVLS-8231
Overview
lambda.requestId. As a result, no function logs appear for an invocation. They still show up for the function, just not not on the invocation.lambda.requestIdandrequestIdinstead of just searching forlambda.requestId. However, I would prefer for On Demand and Lambda Managed Instance Functions to be consistent. So, both using lambda.requestId is preferred.Testing