Skip to content

Conversation

@leandrodamascena
Copy link
Contributor

What does this PR do?

Issue number: #350

Upgrade importlib_metadata version.

Motivation

Avoid issues with transitive dependencies on other projects.

Testing Guidelines

1 - Upgrade the dependency
2 - Executed the tests

image

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@leandrodamascena leandrodamascena requested a review from a team as a code owner July 24, 2023 16:13
@astuyve
Copy link
Contributor

astuyve commented Jul 24, 2023

Hey @leandrodamascena, thanks for this PR! I'm not immediately familiar with this library, my only question would be about the API.

We only call version() from this library and based on the project, that API seems consistent even across all majors:
https://github.com/python/importlib_metadata/blob/maint/3.8.x/importlib_metadata/__init__.py
https://github.com/python/importlib_metadata/blob/maint/2.x/importlib_metadata/__init__.py#L283
https://github.com/python/importlib_metadata/blob/maint/4.x/importlib_metadata/__init__.py#L636
https://github.com/python/importlib_metadata/blob/main/importlib_metadata/__init__.py#L476

Naively I think this will be okay, but I'd like to test this in our long-running test system for a day before publishing a new release.

I'll merge this PR and create a release candidate internally to test, and if everything looks good I will publish a new release.

Thank you so much for this contribution!

@astuyve astuyve merged commit ff0984b into DataDog:main Jul 24, 2023
@leandrodamascena
Copy link
Contributor Author

Hey @astuyve, thanks so much for merging this PR!

You are probably using this library to maintain compatibility with Python version 3.7. As of Python 3.8, Python introduced importlib.metadata into the core, and you can remove the importlib_metadata dependency as long as you drop support for Python 3.7.

I'll wait this new release to update our project!

Have a great week!

@leandrodamascena
Copy link
Contributor Author

Hello @astuyve! Just to get an update here.. Can you test it internally? Hope everything went well.

Do you know if there is an expected date to release this version? I'm coordinating the actions here on my side and would like to remove this block.

Thank you very much for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants